All of lore.kernel.org
 help / color / mirror / Atom feed
From: KOVACS Krisztian <hidden@balabit.hu>
To: "netfilter-devel" <netfilter-devel@lists.netfilter.org>
Cc: Harald Welte <laforge@netfilter.org>,
	Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>
Subject: [PATCH 1/2] nf_conntrack: remove nf_conntrack stat proc file when cleaning up
Date: Sat, 5 Nov 2005 12:49:06 +0100	[thread overview]
Message-ID: <200511051249.06265@nienna> (raw)

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]


  Hi,

  nf_conntrack does not properly remove /proc/net/stat/nf_conntrack when 
cleaning up. The attached patch seems to solve (at least in nfsim).

-- 
 Regards,
  Krisztian Kovacs

[-- Attachment #2: 02-nf_conntrack-remove_stat_proc_file.patch --]
[-- Type: text/x-diff, Size: 1131 bytes --]

[NETFILTER] Remove nf_conntrack stat proc file when cleaning up

Fix nf_conntrack statistics proc file removal. Looks like the old bug
was forward-ported from ip_conntrack. :-]

Signed-off-by: KOVACS Krisztian <hidden@balabit.hu>

---
commit d9c38734c90540ea7c8fb5eb11ff77c05d6dbb40
tree 17fd2f4b3de0ef4b9dc52dc8cbe35924c7482f25
parent a3d662dd415a847d60097d17d6f634429b886b8f
author KOVACS Krisztian <hidden@balabit.hu> Fri, 04 Nov 2005 11:35:48 +0100
committer KOVACS Krisztian <hidden@balabit.hu> Fri, 04 Nov 2005 11:35:48 +0100

 net/netfilter/nf_conntrack_standalone.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/netfilter/nf_conntrack_standalone.c b/net/netfilter/nf_conntrack_standalone.c
index d2ea098..3dd65fe 100644
--- a/net/netfilter/nf_conntrack_standalone.c
+++ b/net/netfilter/nf_conntrack_standalone.c
@@ -694,7 +694,7 @@ static int init_or_cleanup(int init)
  cleanup_proc_stat:
 #endif
 #ifdef CONFIG_PROC_FS
-	proc_net_remove("nf_conntrack_stat");
+	remove_proc_entry("nf_conntrack", proc_net_stat);
  cleanup_proc_exp:
 	proc_net_remove("nf_conntrack_expect");
  cleanup_proc:

                 reply	other threads:[~2005-11-05 11:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200511051249.06265@nienna \
    --to=hidden@balabit.hu \
    --cc=laforge@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=yasuyuki.kozakai@toshiba.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.