From: Al Viro <viro@ftp.linux.org.uk>
To: Ian Campbell <icampbell@arcom.com>,
Wim Van Sebroeck <wim@iguana.be>,
linux-kernel@vger.kernel.org
Subject: Re: [WATCHDOG] sa1100_wdt.c sparse cleanups
Date: Sat, 5 Nov 2005 14:51:34 +0000 [thread overview]
Message-ID: <20051105145134.GL7992@ftp.linux.org.uk> (raw)
In-Reply-To: <20051105101026.GA28438@flint.arm.linux.org.uk>
On Sat, Nov 05, 2005 at 10:10:27AM +0000, Russell King wrote:
> It's probably better to use a union with these, eg:
>
> union {
> void __user *arg;
> struct watchdog_info __user *info;
> int __user *i;
> } u;
>
> u.arg = (void __user *)arg;
>
> ...
>
> ret = copy_to_user(u.info, &ident, sizeof(ident)) ? -EFAULT : 0;
Just use void __user *.
next prev parent reply other threads:[~2005-11-05 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-02 8:56 [WATCHDOG] sa1100_wdt.c sparse cleanups Ian Campbell
2005-11-05 10:10 ` Russell King
2005-11-05 14:51 ` Al Viro [this message]
2005-11-05 17:24 ` Russell King
2005-11-07 10:21 ` Ian Campbell
2006-01-17 19:04 ` Wim Van Sebroeck
2006-01-18 8:45 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051105145134.GL7992@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=icampbell@arcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.