From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1EYSmi-0002nf-39 for mharc-grub-devel@gnu.org; Sat, 05 Nov 2005 13:29:00 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EYSmf-0002m4-4I for grub-devel@gnu.org; Sat, 05 Nov 2005 13:28:57 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EYSmc-0002jS-0b for grub-devel@gnu.org; Sat, 05 Nov 2005 13:28:55 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EYSmb-0002iu-F7 for grub-devel@gnu.org; Sat, 05 Nov 2005 13:28:53 -0500 Received: from [212.85.152.101] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EYSmb-0004iv-Dx for grub-devel@gnu.org; Sat, 05 Nov 2005 13:28:53 -0500 Received: from ASSP-nospam (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id 6370B3C801D39 for ; Sat, 5 Nov 2005 19:33:32 +0100 (CET) Received: from 127.0.0.1 ([127.0.0.1] helo=ip6-localhost) by ASSP-nospam ; 5 Nov 05 18:33:32 -0000 From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sat, 5 Nov 2005 19:28:49 +0100 User-Agent: KMail/1.7.2 References: <436CBF00.1060304@yahoo.fr> In-Reply-To: <436CBF00.1060304@yahoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200511051928.49549.okuji@enbug.org> Subject: Re: play.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Nov 2005 18:28:58 -0000 On Saturday 05 November 2005 03:17 pm, Vincent Pelletier wrote: > Here is the play command, along with some songs. I point out some stylish mistakes. > +struct note { > + =A0short pitch; > + =A0short duration; > +}; You must put the starting brace character on next line: struct note { short pitch; short duration; }; > + =A0while (grub_file_read (file, (void *) &buf, sizeof(struct note)) =3D= =3D=20 sizeof(struct note) && > + =A0 =A0 =A0 =A0 buf.pitch !=3D T_FINE && > + =A0 =A0 =A0 =A0 grub_checkkey () =3D=3D -1) The lines are folded incorrectly. You must insert new lines before logical= =20 operations. Also, please add a space character after sizeof: while (grub_file_read (file, (void *) &buf, sizeof (struct note)) =3D=3D si= zeof=20 (struct note) && buf.pitch !=3D T_FINE && grub_checkkey () =3D=3D -1) > + =A0 =A0 =A0to =3D grub_get_rtc () + 120*buf.duration/tempo; Insert space characters. Okuji