From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
ext2-devel@lists.sourceforge.net, ext3-users@redhat.com,
linux-xfs@oss.sgi.com, xfs-masters@oss.sgi.com, nathans@sgi.com,
reiserfs-dev@namesys.com, zippel@linux-m68k.org,
sfrench@samba.org, samba-technical@lists.samba.org
Subject: Re: [PATCH 10/25] fs: move ext2 ioctl32 handlers into file systems
Date: Sun, 6 Nov 2005 05:39:42 +0100 [thread overview]
Message-ID: <20051106043942.GA31343@lst.de> (raw)
In-Reply-To: <20051105162714.555612000@b551138y.boeblingen.de.ibm.com>
On Sat, Nov 05, 2005 at 05:27:00PM +0100, Arnd Bergmann wrote:
> The same ioctls (originally from ext2) are used on ext2, ext3,
> hfsplus, cifs, reiserfs and xfs. Since they are really compatible
> between 32 and 64 bit except for the ioctl number, the conversion
> handler is trivial and I copy it to each of these file systems
> in order to eventually get rid of fs/compat_ioctl.c completely.
NACK, this is completely idiotic. Duplicating handlers is the very
last thing we want. I actually have patches to move handling some
of those ioctls into generic code, but that's a different story.
next prev parent reply other threads:[~2005-11-06 4:40 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-05 16:26 [PATCH 00/25] reduce code in fs/compat_ioctl.c Arnd Bergmann
2005-11-05 18:06 ` [lm-sensors] " Arnd Bergmann
2005-11-05 16:26 ` Arnd Bergmann
2005-11-05 16:26 ` Arnd Bergmann
2005-11-05 16:26 ` [PATCH 01/25] compat: Remove leftovers from register_ioctl32_conversion Arnd Bergmann
2005-11-05 16:44 ` Al Viro
2005-11-05 17:04 ` Andi Kleen
2005-11-05 16:26 ` [PATCH 02/25] net: move socket ioctl32 to net/compat.c Arnd Bergmann
2005-11-05 16:26 ` [PATCH 03/25] net: improve ioctl32 dev_ioctl handling Arnd Bergmann
2005-11-05 16:26 ` [PATCH 04/25] net: move atm ioctl32 to net/atm/ioctl.c Arnd Bergmann
2005-11-05 16:26 ` [PATCH 05/25] net: move ppp specific ioctl32 handlers Arnd Bergmann
2005-11-05 16:26 ` Arnd Bergmann
2005-11-05 16:26 ` [PATCH 06/25] mtd: move ioctl32 code to mtdchar.c Arnd Bergmann
2005-11-05 16:26 ` Arnd Bergmann
2005-11-08 10:59 ` Jörn Engel
2005-11-08 10:59 ` Jörn Engel
2005-11-08 18:10 ` Eric W. Biederman
2005-11-08 18:10 ` Eric W. Biederman
2005-11-08 18:33 ` Jörn Engel
2005-11-08 18:33 ` Jörn Engel
2005-11-08 18:45 ` Josh Boyer
2005-11-08 18:45 ` Josh Boyer
2005-11-08 18:57 ` Thomas Gleixner
2005-11-08 18:57 ` Thomas Gleixner
2005-11-08 22:21 ` Jörn Engel
2005-11-08 22:21 ` Jörn Engel
2005-11-09 0:04 ` Thomas Gleixner
2005-11-08 19:03 ` David Woodhouse
2005-11-08 19:03 ` David Woodhouse
2005-11-09 15:37 ` Eric W. Biederman
2005-11-09 15:37 ` Eric W. Biederman
2005-11-09 15:48 ` Jörn Engel
2005-11-09 15:48 ` Jörn Engel
2005-11-05 16:26 ` [PATCH 07/25] block: move ioctl32 code to drivers/block/ioctl.c Arnd Bergmann
2005-11-05 16:26 ` [PATCH 08/25] tty: move ioctl32 code over to vt_ioctl.c and tty_io.c Arnd Bergmann
2005-11-05 16:26 ` [PATCH 09/25] v4l: move ioctl32 handlers to drivers/media/ Arnd Bergmann
2005-11-06 4:13 ` Mauro Carvalho Chehab
2005-11-07 10:17 ` Arnd Bergmann
2005-11-12 14:35 ` Mauro Carvalho Chehab
2005-11-05 16:27 ` [PATCH 10/25] fs: move ext2 ioctl32 handlers into file systems Arnd Bergmann
2005-11-06 4:39 ` Christoph Hellwig [this message]
2005-11-07 10:24 ` Arnd Bergmann
2005-11-05 16:27 ` [PATCH 11/25] framebuffer: move ioctl32 code to fbmem.c Arnd Bergmann
2005-11-06 0:16 ` Antonino A. Daplas
2005-11-06 0:16 ` Antonino A. Daplas
2005-11-05 16:27 ` [PATCH 12/25] scsi: move SG_IO ioctl32 code to sg.c Arnd Bergmann
2005-11-05 16:44 ` James Bottomley
2005-11-05 19:19 ` Arnd Bergmann
2005-11-05 16:27 ` [PATCH 13/25] loop: move ioctl32 code to loop.c Arnd Bergmann
2005-11-07 3:33 ` Christoph Hellwig
2005-11-05 16:27 ` [PATCH 14/25] smbfs: simplify compat_ioctl handling Arnd Bergmann
2005-11-05 16:27 ` [PATCH 15/25] autofs: move ioctl32 to autofs{,4}/root.c Arnd Bergmann
2005-11-06 6:22 ` Ian Kent
2005-11-07 10:36 ` Arnd Bergmann
2005-11-07 16:02 ` Ian Kent
2005-11-08 16:23 ` Ian Kent
2005-11-05 16:27 ` [PATCH 16/25] ncpfs: move ioctl32 code to fs/ncpfs/ioctl.c Arnd Bergmann
2005-11-05 16:27 ` [PATCH 17/25] vfat: move ioctl32 code to fs/fat/dir.c Arnd Bergmann
2005-11-06 12:05 ` OGAWA Hirofumi
2005-11-07 10:41 ` Arnd Bergmann
2005-11-07 3:37 ` Christoph Hellwig
2005-11-07 10:42 ` Arnd Bergmann
2005-11-05 16:27 ` [PATCH 18/25] raw: move ioctl32 code to raw.c Arnd Bergmann
2005-11-06 13:59 ` Adrian Bunk
2005-11-07 10:43 ` Arnd Bergmann
2005-11-05 16:27 ` [PATCH 19/25] usbdevfs: move ioctl32 into devio.c Arnd Bergmann
2005-11-05 16:27 ` [PATCH 20/25] i2c: move ioctl32 code to i2c-dev.c Arnd Bergmann
2005-11-05 17:35 ` [lm-sensors] " Arnd Bergmann
2005-11-05 16:27 ` [PATCH 21/25] reiserfs: remove ioctl conversion code Arnd Bergmann
2005-11-05 16:27 ` [PATCH 22/25] serial: move ioctl32 code to tty_io.c Arnd Bergmann
2005-11-05 16:27 ` [PATCH 23/25] cdrom: move ioctl32 code to drivers/cdrom/compat.c Arnd Bergmann
2005-11-05 16:27 ` [PATCH 24/25] tape: move mtio ioctl32 code to driver/char/compat_mtio.c Arnd Bergmann
2005-11-05 16:27 ` [PATCH 25/25] bluetooth: integrate ioctl32 handling Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051106043942.GA31343@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=ext2-devel@lists.sourceforge.net \
--cc=ext3-users@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@oss.sgi.com \
--cc=nathans@sgi.com \
--cc=reiserfs-dev@namesys.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=xfs-masters@oss.sgi.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.