From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH]: nfsd: more vfs_getxattr Date: Sun, 6 Nov 2005 22:21:43 -0800 Message-ID: <20051106222143.765bdb18.akpm@osdl.org> References: <20051107053657.GA18278@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: neilb@cse.unsw.edu.au, linux-fsdevel@vger.kernel.org Return-path: Received: from smtp.osdl.org ([65.172.181.4]:29420 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S964792AbVKGGWA (ORCPT ); Mon, 7 Nov 2005 01:22:00 -0500 To: Christoph Hellwig In-Reply-To: <20051107053657.GA18278@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Christoph Hellwig wrote: > > looks like I missed NFSv4 previously. When sending fixes for earlier patches, it greatly helps if you can identify which patch it is that needs fixing. Usually it's obvious, but in this case it's not. > + *buf = kmalloc(buflen, GFP_KERNEL); > + if (!buf) > + return -ENOMEM; That's obviously broken.