All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@kernel.crashing.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Fix 8250 probe on ppc32
Date: Mon, 7 Nov 2005 09:09:39 -0700	[thread overview]
Message-ID: <20051107160939.GD3839@smtp.west.cox.net> (raw)
In-Reply-To: <1131357857.27347.28.camel@baythorne.infradead.org>

On Mon, Nov 07, 2005 at 10:04:17AM +0000, David Woodhouse wrote:

> This fairly much obsoletes include/asm-ppc/pc_serial.h -- other machines
> with 8250 ports which are currently responsible for the mess in
> include/asm-ppc/serial.h itself should be converted to a platform_device
> of their own before they become supported in arch/powerpc.

That depends on what we're going to expect out of arch/powerpc/boot,
which I'm talking with Paul about.  But..

> --- /dev/null	2005-10-08 11:44:47.528646500 +0100
> +++ b/drivers/serial/8250_of.c	2005-11-07 09:51:22.000000000 +0000
> @@ -0,0 +1,197 @@
> +#include <linux/kernel.h>
[snip]
> +#if 0
> +#define DBG(fmt...) printk(KERN_DEBUG fmt)
> +#else
> +#define DBG(fmt...) do { } while (0)
> +#endif

pr_debug(), line wrap and a legal boilerplate
(arch/ppc/platforms/lopec.c has the smallest one our laywers could come
up with) ? :)

-- 
Tom Rini
http://gate.crashing.org/~trini/

  reply	other threads:[~2005-11-07 16:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-07 10:04 [PATCH] Fix 8250 probe on ppc32 David Woodhouse
2005-11-07 16:09 ` Tom Rini [this message]
2005-11-07 16:20   ` David Woodhouse
2005-11-07 16:31     ` Tom Rini
2005-11-07 17:25       ` Dan Malek
2005-11-07 16:54     ` Christoph Hellwig
2005-11-07 17:02       ` David Woodhouse
2005-11-16  8:51         ` David Woodhouse
2005-11-16  9:12           ` Paul Mackerras
2005-11-16 10:25             ` David Woodhouse
2005-11-16 15:24               ` Kumar Gala
2005-11-18  1:12               ` Paul Mackerras
2005-11-18  3:26                 ` Kumar Gala
2005-11-18  3:50                   ` Benjamin Herrenschmidt
2005-11-18  8:23                     ` Christoph Hellwig
2005-11-18 10:51                       ` Benjamin Herrenschmidt
2005-11-18 14:46                         ` Kumar Gala
2005-11-18 21:36                           ` Benjamin Herrenschmidt
2005-11-18 21:39                             ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051107160939.GD3839@smtp.west.cox.net \
    --to=trini@kernel.crashing.org \
    --cc=dwmw2@infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.