From: Adrian Bunk <bunk@stusta.de>
To: David Teigland <teigland@redhat.com>
Cc: linux-cluster@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] drivers/dlm/: possible cleanups
Date: Mon, 7 Nov 2005 21:20:52 +0100 [thread overview]
Message-ID: <20051107202051.GQ3847@stusta.de> (raw)
In-Reply-To: <20051107200431.GC20531@redhat.com>
On Mon, Nov 07, 2005 at 02:04:31PM -0600, David Teigland wrote:
> On Fri, Nov 04, 2005 at 01:06:40PM +0100, Adrian Bunk wrote:
> > This patch contains the following possible cleanups:
> > - every file should #include the headers containing the prototypes for
> > it's global functions
>
> Including unnecessary headers doesn't sound right.
>...
They aren't unnecessary.
If you #include them, gcc can tell when the prototypes in the header and
the C file are accidentially different.
Without the #include's, this would result in a nasty runtime error.
> Thanks,
> Dave
cu
Adrian
BTW: Please ignore the resending of this patch that overlapped with
your answer.
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-11-07 20:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 12:06 [-mm patch] drivers/dlm/: possible cleanups Adrian Bunk
2005-11-07 20:04 ` David Teigland
2005-11-07 20:20 ` Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-11-07 20:04 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051107202051.GQ3847@stusta.de \
--to=bunk@stusta.de \
--cc=linux-cluster@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.