From: Ingo Molnar <mingo@elte.hu>
To: Zachary Amsden <zach@vmware.com>
Cc: Andrew Morton <akpm@osdl.org>, Chris Wright <chrisw@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
Martin Bligh <mbligh@mbligh.org>,
Pratap Subrahmanyam <pratap@vmware.com>,
Christopher Li <chrisl@vmware.com>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH 16/21] i386 Eliminate duplicate segment macros
Date: Tue, 8 Nov 2005 08:36:35 +0100 [thread overview]
Message-ID: <20051108073635.GF28201@elte.hu> (raw)
In-Reply-To: <200511080436.jA84aGvD009933@zach-dev.vmware.com>
* Zachary Amsden <zach@vmware.com> wrote:
> +#define get_desc_32bit(desc) (((desc)->b >> 22) & 1)
> +#define get_desc_contents(desc) (((desc)->b >> 10) & 3)
> +#define get_desc_writable(desc) (((desc)->b >> 9) & 1)
> +#define get_desc_gran(desc) (((desc)->b >> 23) & 1)
> +#define get_desc_present(desc) (((desc)->b >> 15) & 1)
> +#define get_desc_usable(desc) (((desc)->b >> 20) & 1)
naming nit: shouldnt they be 'desc_32bit()/desc_writable()/...'? No need
for the get_ i think.
Ingo
next prev parent reply other threads:[~2005-11-08 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-08 4:36 [PATCH 16/21] i386 Eliminate duplicate segment macros Zachary Amsden
2005-11-08 7:36 ` Ingo Molnar [this message]
2005-11-10 14:09 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051108073635.GF28201@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=chrisl@vmware.com \
--cc=chrisw@osdl.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@mbligh.org \
--cc=pratap@vmware.com \
--cc=torvalds@osdl.org \
--cc=virtualization@lists.osdl.org \
--cc=zach@vmware.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.