All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Greg KH <gregkh@suse.de>
Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/usb/core/message.c: make usb_get_string() static
Date: Tue, 8 Nov 2005 21:05:43 +0100	[thread overview]
Message-ID: <20051108200543.GF3847@stusta.de> (raw)
In-Reply-To: <20051108184638.GA15939@suse.de>

After the removal of usb-midi.c, there's no longer any external user of 
usb_get_string().


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/usb/core/message.c |    5 ++---
 include/linux/usb.h        |    2 --
 2 files changed, 2 insertions(+), 5 deletions(-)

--- linux-2.6.14-mm1-full/include/linux/usb.h.old	2005-11-08 18:42:15.000000000 +0100
+++ linux-2.6.14-mm1-full/include/linux/usb.h	2005-11-08 18:42:23.000000000 +0100
@@ -1004,8 +1004,6 @@
 	unsigned char descindex, void *buf, int size);
 extern int usb_get_status(struct usb_device *dev,
 	int type, int target, void *data);
-extern int usb_get_string(struct usb_device *dev,
-	unsigned short langid, unsigned char index, void *buf, int size);
 extern int usb_string(struct usb_device *dev, int index,
 	char *buf, size_t size);
 
--- linux-2.6.14-mm1-full/drivers/usb/core/message.c.old	2005-11-08 18:42:32.000000000 +0100
+++ linux-2.6.14-mm1-full/drivers/usb/core/message.c	2005-11-08 18:42:58.000000000 +0100
@@ -637,8 +637,8 @@
  * Returns the number of bytes received on success, or else the status code
  * returned by the underlying usb_control_msg() call.
  */
-int usb_get_string(struct usb_device *dev, unsigned short langid,
-		unsigned char index, void *buf, int size)
+static int usb_get_string(struct usb_device *dev, unsigned short langid,
+			  unsigned char index, void *buf, int size)
 {
 	int i;
 	int result;
@@ -1488,7 +1488,6 @@
 // synchronous control message convenience routines
 EXPORT_SYMBOL(usb_get_descriptor);
 EXPORT_SYMBOL(usb_get_status);
-EXPORT_SYMBOL(usb_get_string);
 EXPORT_SYMBOL(usb_string);
 
 // synchronous calls that also maintain usbcore state


      parent reply	other threads:[~2005-11-08 20:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-08 18:12 [2.6 patch] remove USB_AUDIO and USB_MIDI drivers Adrian Bunk
2005-11-08 18:46 ` Greg KH
2005-11-08 18:50   ` Adrian Bunk
2005-11-08 20:05   ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051108200543.GF3847@stusta.de \
    --to=bunk@stusta.de \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.