From: Christoph Hellwig <hch@lst.de>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] display7seg: implement ->unlocked_ioctl and ->compat_ioctl
Date: Tue, 08 Nov 2005 21:21:09 +0000 [thread overview]
Message-ID: <20051108212109.GA26444@lst.de> (raw)
In-Reply-To: <20051107194232.GD32019@lst.de>
On Tue, Nov 08, 2005 at 01:19:21PM -0800, Eric Brower wrote:
> On 11/8/05, Christoph Hellwig <hch@lst.de> wrote:
> > On Tue, Nov 08, 2005 at 12:48:57PM -0800, Eric Brower wrote:
> > > Are we intentionally locking the kernel twice in the ioctl handler?
> >
> > No. Otoh the BKL is recursive so it doesn't matter.
>
> I'm speaking specifically of the patch doing the following within the
> driver's ioctl handler:
>
> lock_kernel()
> ... handle ioctl
> lock_kernel()
>
> We ought to be calling unlock_kernel() at the end, correct?
Umm, yes. Sorry, this is a typo and the second one should be a
unlock_kernel().
next prev parent reply other threads:[~2005-11-08 21:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-07 19:42 [PATCH] display7seg: implement ->unlocked_ioctl and ->compat_ioctl Christoph Hellwig
2005-11-07 21:56 ` [PATCH] display7seg: implement ->unlocked_ioctl and David S. Miller
2005-11-08 20:48 ` [PATCH] display7seg: implement ->unlocked_ioctl and ->compat_ioctl Eric Brower
2005-11-08 20:55 ` Christoph Hellwig
2005-11-08 21:19 ` Eric Brower
2005-11-08 21:21 ` Christoph Hellwig [this message]
2005-11-09 20:05 ` [PATCH] display7seg: implement ->unlocked_ioctl and David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051108212109.GA26444@lst.de \
--to=hch@lst.de \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.