All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: Ashok Raj <ashok.raj@intel.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, gregkh@suse.de
Subject: Re: Changing MSI to use physical delivery mode always.
Date: 9 Nov 2005 14:56:50 +0100
Date: Wed, 9 Nov 2005 14:56:50 +0100	[thread overview]
Message-ID: <20051109135650.GA78272@muc.de> (raw)
In-Reply-To: <20051108070038.A15318@unix-os.sc.intel.com>

On Tue, Nov 08, 2005 at 07:00:38AM -0800, Ashok Raj wrote:
> Hi,
> 
> MSI was hard coded to use logical delivery mode for i386/x86_64 and 
> physical mode for ia64.
> 
> With recent x86_64 we moved to physical flat mode that broke MSI.
> 
> Made MSI to work with physical mode, this will be consistent on all
> archs. 

Nasty bug. Thanks for tracking that down.

It is outright scary though that such deeply architecture specific
code is in drivers/pci. It should be in arch. I think that was
because I missed it. Would you be willing to move the APIC specific parts 
to arch/i386/pci ? 

-Andi


  reply	other threads:[~2005-11-09 13:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-08 15:00 Changing MSI to use physical delivery mode always Ashok Raj
2005-11-09 13:56 ` Andi Kleen [this message]
2005-11-09 19:50   ` Ashok Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051109135650.GA78272@muc.de \
    --to=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=ashok.raj@intel.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.