All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk: cfq forced dispatching fix
Date: Thu, 10 Nov 2005 08:47:39 +0100	[thread overview]
Message-ID: <20051110074738.GR3699@suse.de> (raw)
In-Reply-To: <20051109171758.GC24115@htj.dyndns.org>

On Thu, Nov 10 2005, Tejun Heo wrote:
> cfq forced dispatching might not return all requests on the queue.
> This bug can hang elevator switchinig and corrupt request ordering
> during flush sequence.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> 
> ---
> 
> Jens, I implemented a separate code path for forced dispatching as it
> seemed too complex/error-prone to handle forced case in normal
> dispatch path.  How do you like this approach?

I like this approach better then mixing the 'force' into various logic
around the function. So applied.

-- 
Jens Axboe


      reply	other threads:[~2005-11-10  7:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-09 17:17 [PATCH] blk: cfq forced dispatching fix Tejun Heo
2005-11-10  7:47 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051110074738.GR3699@suse.de \
    --to=axboe@suse.de \
    --cc=htejun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.