All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk: implement elv_drain_elevator
Date: Thu, 10 Nov 2005 08:52:53 +0100	[thread overview]
Message-ID: <20051110075253.GS3699@suse.de> (raw)
In-Reply-To: <20051109173257.GD24115@htj.dyndns.org>

On Thu, Nov 10 2005, Tejun Heo wrote:
> This patch adds request_queue->nr_sorted which keeps the number of
> requests in the iosched and implement elv_drain_elevator which
> performs forced dispatching.  elv_drain_elevator checks whether
> iosched actually dispatches all requests it has and prints error
> message if it doesn't.  As buggy forced dispatching can result in
> wrong barrier operations, I think this extra check is worthwhile.

Yeah I agree, especially as it's potentially data integrity violating
with this kind of bug. Applied.

-- 
Jens Axboe


      reply	other threads:[~2005-11-10  7:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-09 17:32 [PATCH] blk: implement elv_drain_elevator Tejun Heo
2005-11-10  7:52 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051110075253.GS3699@suse.de \
    --to=axboe@suse.de \
    --cc=htejun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.