All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Alex Williamson <alex.williamson@hp.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] backup timer for UARTs that lose interrupts
Date: Thu, 10 Nov 2005 10:44:19 +0000	[thread overview]
Message-ID: <20051110104419.GA20693@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1131495392.9657.9.camel@tdi>

On Tue, Nov 08, 2005 at 05:16:32PM -0700, Alex Williamson wrote:
>   I was hoping that would be the solution too.  I just tried enabling
> UART_BUG_TXEN to double check my previous results.  Somehow it makes the
> problem much, much worse.  Instead of being the nuisance it usually is,
> it seems like the UART gets way behind on transmitting bits.  So it
> would probably prevent the unattended reboot stall since we kick it
> every time we want to transmit, but it renders the UART completely
> unusable as a console.  I can't even get it caught up enough to login
> via the serial console w/ UART_BUG_TXEN enabled on the port.  Thanks,

Ok, would you mind fixing the patch so it isn't screwing up the
default use of up->timer please?  You may notice that this timer
is already used, and overwriting up->timer.function is a one-way
process in your patch (which kills off the point of serial8250_timeout).

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

  reply	other threads:[~2005-11-10 10:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-08 20:27 [PATCH] backup timer for UARTs that lose interrupts Alex Williamson
2005-11-08 23:23 ` Russell King
2005-11-09  0:16   ` Alex Williamson
2005-11-10 10:44     ` Russell King [this message]
2005-11-10 13:38       ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051110104419.GA20693@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=alex.williamson@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.