All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	James Bottomley <James.Bottomley@SteelEye.com>,
	Linux-SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/3]  qla2xxx: Add full firmware(-request) hotplug support for all ISPs.
Date: Fri, 11 Nov 2005 07:30:02 +0000	[thread overview]
Message-ID: <20051111073002.GA3233@infradead.org> (raw)
In-Reply-To: <20051111004718.GP5678@andrew-vasquezs-powerbook-g4-15.local>

On Thu, Nov 10, 2005 at 04:47:18PM -0800, Andrew Vasquez wrote:
> Sure, sounds reasonable -- perhaps we can get some consensus from the
> list and come up with the date (arbitrary as it may be), at least it
> would motivate those affected (QLogic)...

sure.  Does June 2006 sounds reasonable?

> > > +config SCSI_QLA21XX
> > > +	tristate "  Build QLogic ISP2100 firmware-module"
> > > +	depends on SCSI_QLA2XXX_EMBEDDED_FIRMWARE
> > >  	---help---
> > >  	This driver supports the QLogic 21xx (ISP2100) host adapter family.
> > 
> > don't the help-text need some update?
> 
> I'm inclined to drop the help-text entirely for the firmware-module
> entries, as I'm not sure one needs more info than the menu-item:
> 
> 	[ ] Build QLogic ISP2100 firmware-module
> 
> already states.  What were you looking for?

Dropping the help text makes sense.

> > I'd say just use this else clause unconditionally.  no need to optimize for
> > the 1% users using the deprecated builtin-firmware and compile just for
> > a subsystet of the supported cards.
> 
> As this patchset looks to be more 2.6.16 material, I'll redo the
> patches with this change along with any additional feedback and a few
> minor bits.
> 
> James, would you like me to resubmit now for staging in scsi-misc-2.6
> for 2.6.16?

Given that it's needed to support the ISP24xx i'd love to see it in
2.6.15


  reply	other threads:[~2005-11-11  7:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-09 23:48 [PATCH 0/3] qla2xxx: deprecate usage of firmware-loader modules Andrew Vasquez
2005-11-09 23:49 ` [PATCH 1/3] qla2xxx: Add full firmware(-request) hotplug support for all ISPs Andrew Vasquez
2005-11-10 10:58   ` Christoph Hellwig
2005-11-11  0:47     ` Andrew Vasquez
2005-11-11  7:30       ` Christoph Hellwig [this message]
2005-11-11  8:08         ` Andrew Vasquez
2005-11-09 23:49 ` [PATCH 2/3] qla2xxx: Add support for embedded ISP24xx firmware Andrew Vasquez
2005-11-09 23:49 ` [PATCH 3/3] qla2xxx: Resync with latest released ISP24xx firmware -- 4.00.16 Andrew Vasquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051111073002.GA3233@infradead.org \
    --to=hch@infradead.org \
    --cc=James.Bottomley@SteelEye.com \
    --cc=andrew.vasquez@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.