All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@osdl.org, netdev@vger.kernel.org, parisc-linux@parisc-linux.org
Subject: [parisc-linux] Re: [PATCH] parisc: remove copat_ioctl entires for pp
Date: Sat, 12 Nov 2005 06:33:08 -0700	[thread overview]
Message-ID: <20051112133308.GI1658@parisc-linux.org> (raw)
In-Reply-To: <20051112095213.GA15918@lst.de>

On Sat, Nov 12, 2005 at 10:52:13AM +0100, Christoph Hellwig wrote:
> ppp ioctls handlers in parisc are wrong:
> 
>  - they would need to do a copat_ptr on  ifr->ifr_ifru.ifru_data
>  - SIOCGPPP* ioctls are defines as SIOCDEVPRIVATE + n, so they'd
>    kick in for all private ioctls which is defintely wrong.
> 
> to implement proper ppp compat_ioctl handlig we'd need a compat_ioctl
> method in struct net_device, which we don't have yet.

While I agree that this is theoretically wrong, the problem is that if
we remove them, people using ppp on 64-bit PA machines will no longer be
able to do so.  And yes, there are some, that's why these got added in
the first place.

Perhaps I'll look into the compat_ioctl route later.  In any case, I
would prefer this patch not be added for the moment.
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

           reply	other threads:[~2005-11-12 13:33 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20051112095213.GA15918@lst.de>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051112133308.GI1658@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=akpm@osdl.org \
    --cc=hch@lst.de \
    --cc=netdev@vger.kernel.org \
    --cc=parisc-linux@parisc-linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.