From: Jean Delvare <khali@linux-fr.org>
To: Nick Warne <nick@linicks.net>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext3: Fix warning without quota support (was: Linux 2.6.14)
Date: Sat, 12 Nov 2005 16:31:53 +0100 [thread overview]
Message-ID: <20051112163153.6b54ee83.khali@linux-fr.org> (raw)
In-Reply-To: <200511121412.35029.nick@linicks.net>
Hi Nick,
> > Fix the following warning when ext3 fs is compiled without quota
> > support:
> >
> > fs/ext3/super.c: In function `ext3_show_options':
> > fs/ext3/super.c:516: warning: unused variable `sbi'
>
> I have added this small fix to my 2.6.14.2 build. A quick question.
Let is be noted that this warning was fixed in a completely different
way in Linus' tree already. My patch is not meant for -stable either,
as it doesn't fix any real problem.
> What does GCC do here - does it just drop and ignore the unused variable?
Without optimizations, gcc 3.3.6 keeps the variable although it won't
ever be used. With -O1 and above (including -Os) it drops the unused
variable.
--
Jean Delvare
next prev parent reply other threads:[~2005-11-12 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-12 14:12 [PATCH] ext3: Fix warning without quota support (was: Linux 2.6.14) Nick Warne
2005-11-12 15:31 ` Jean Delvare [this message]
2005-11-12 15:58 ` Nick Warne
-- strict thread matches above, loose matches on Subject: below --
2005-10-28 0:28 Linux 2.6.14 Linus Torvalds
2005-10-28 16:49 ` [PATCH] ext3: Fix warning without quota support (was: Linux 2.6.14) Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051112163153.6b54ee83.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@linicks.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.