From: Christophe Lucas <clucas@rotomalug.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/block/floppy.c: trivial printk() updates
Date: Mon, 14 Nov 2005 08:21:43 +0000 [thread overview]
Message-ID: <20051114082143.GG513@rotomalug.org> (raw)
In-Reply-To: <200511140835.20684.daniel.marjamaki@comhem.se>
Daniel Marjamäki (daniel.marjamaki@comhem.se) wrote:
>
> This is a trivial update that inserts appropriate KERN_ in printk() calls.
>
> Signed-off-by: Daniel Marjamäki
>
>
> --- linux-2.6.14.1.orig/drivers/block/floppy.c 2005-11-14 08:14:40.000000000 +0100
> +++ linux-2.6.14.1/drivers/block/floppy.c 2005-11-14 08:25:46.000000000 +0100
> @@ -310,7 +310,7 @@ static int initialising = 1;
> #define USETF(x) (set_bit(x##_BIT, &UDRS->flags))
> #define UTESTF(x) (test_bit(x##_BIT, &UDRS->flags))
>
> -#define DPRINT(format, args...) printk(DEVICE_NAME "%d: " format, current_drive , ## args)
> +#define DPRINT(format, args...) printk(KERN_INFO DEVICE_NAME "%d: " format, current_drive , ## args)
>
> #define PH_HEAD(floppy,head) (((((floppy)->stretch & 2) >>1) ^ head) << 2)
> #define STRETCH(floppy) ((floppy)->stretch & FD_STRETCH)
> @@ -620,7 +620,7 @@ static inline void set_debugt(void)
> static inline void debugt(const char *message)
> {
> if (DP->flags & DEBUGT)
> - printk("%s dtime=%lu\n", message, jiffies - debugtimer);
> + printk(KERN_INFO "%s dtime=%lu\n", message, jiffies - debugtimer);
> }
Are you sure for this one ?
I will put KERN_DEBUG instead of KERN_INFO :)
Have a nice day,
- Christophe (clucas@rotomalug.org)
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-11-14 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-14 7:35 [KJ] [PATCH] drivers/block/floppy.c: trivial printk() updates Daniel Marjamäki
2005-11-14 8:21 ` Christophe Lucas [this message]
2005-11-14 10:03 ` Daniel Marjamäki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051114082143.GG513@rotomalug.org \
--to=clucas@rotomalug.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.