All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] PCI Error Recovery: header file patch
Date: Mon, 14 Nov 2005 14:35:59 -0800	[thread overview]
Message-ID: <20051114223559.GA6058@kroah.com> (raw)
In-Reply-To: <20051108161158.51ef0d34@dxpl.pdx.osdl.net>

On Tue, Nov 08, 2005 at 04:11:58PM -0800, Stephen Hemminger wrote:
> 
> >  
> > +/** The pci_channel state describes connectivity between the CPU and
> > + *  the pci device.  If some PCI bus between here and the pci device
> > + *  has crashed or locked up, this info is reflected here.
> > + */
> > +typedef int __bitwise pci_channel_state_t;
> 
> Bit operations should be on unsigned not signed value.

Agreed.  I'll wait for Linas to respin these.

thanks,

greg k-h

  reply	other threads:[~2005-11-14 22:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-08 23:49 [PATCH 0/7] PCI Error Recovery linas
2005-11-08 23:53 ` [PATCH 1/7] PCI Error Recovery: header file patch linas
2005-11-09  0:11   ` Stephen Hemminger
2005-11-14 22:35     ` Greg KH [this message]
2005-11-16 23:10   ` linas
2005-11-17 23:44     ` Greg KH
2005-11-08 23:55 ` [PATCH 2/7] PCI Error Recovery: IPR SCSI device driver linas
2005-11-08 23:57 ` [PATCH 3/7] PCI Error Recovery: Symbios " linas
2005-11-08 23:58 ` [PATCH 4/7] PCI Error Recovery: e100 network " linas
2005-11-09  0:00 ` [PATCH 5/7] PCI Error Recovery: e1000 " linas
2005-11-09  0:01 ` [PATCH 6/7] PCI Error Recovery: ixgb " linas
2005-11-09  0:03 ` [PATCH 7/7] PCI Error Recovery: CONFIG_PCI_ERROR_RECOVERY wrappers linas
2005-11-14 21:47 ` [PATCH 0/7] PCI Error Recovery linas
2005-11-15 16:49   ` Greg KH
2005-11-15 17:59     ` linas
2005-11-15 21:56       ` Paul Mackerras
2005-11-16  0:54         ` linas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051114223559.GA6058@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.