All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Adam Belay <abelay@novell.com>
Cc: Linux-pm mailing list <linux-pm@lists.osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 5/6] PCI PM: kzalloc() cleanup
Date: Tue, 15 Nov 2005 22:22:57 -0800	[thread overview]
Message-ID: <20051116062257.GC31375@suse.de> (raw)
In-Reply-To: <1132111891.9809.57.camel@localhost.localdomain>

On Tue, Nov 15, 2005 at 10:31:31PM -0500, Adam Belay wrote:
> Use kzalloc() instead of kmalloc() and memset().
> 
> 
> --- a/drivers/pci/pm.c	2005-11-08 17:10:37.000000000 -0500
> +++ b/drivers/pci/pm.c	2005-11-08 17:11:33.000000000 -0500
> @@ -300,12 +300,10 @@
>  		return -EIO;
>  	}
>  
> -	dev->pm = pm_data = kmalloc(sizeof(struct pci_dev_pm), GFP_KERNEL);
> +	dev->pm = pm_data = kzalloc(sizeof(struct pci_dev_pm), GFP_KERNEL);
>  	if (!pm_data)
>  		return -ENOMEM;
>  
> -	memset(pm_data, 0, sizeof(struct pci_dev_pm));
> -

You can merge this back with your other patch :)

thanks,

greg k-h

  reply	other threads:[~2005-11-16  6:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-16  3:31 [RFC][PATCH 5/6] PCI PM: kzalloc() cleanup Adam Belay
2005-11-16  6:22 ` Greg KH [this message]
2005-11-16  7:21   ` Adam Belay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051116062257.GC31375@suse.de \
    --to=gregkh@suse.de \
    --cc=abelay@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.