Re: [UPDATE PATCH] acpi/video: check brightness is non-NULL before writing

[Nishanth Aravamudan <nacc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>]

On 17.11.2005 [14:30:16 +0800], Yu, Luming wrote:
> On Thursday 17 November 2005 04:43, Nishanth Aravamudan wrote:
> >
> > Signed-off-by: Nishanth Aravamudan <nacc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> >
> > ---
> >
> >  drivers/acpi/video.c |    2 +-
> >  1 files changed, 1 insertion(+), 1 deletion(-)
> >
> > diff -urpN 2.6.15-rc1/drivers/acpi/video.c
> > 2.6.15-rc1-dev/drivers/acpi/video.c ---
> > 2.6.15-rc1/drivers/acpi/video.c	2005-11-11 20:32:50.000000000 -0800 +++
> > 2.6.15-rc1-dev/drivers/acpi/video.c	2005-11-16 12:40:42.000000000 -0800 @@
> > -812,7 +812,7 @@ acpi_video_device_write_brightness(struc
> >
> >  	ACPI_FUNCTION_TRACE("acpi_video_device_write_brightness");
> >
> > -	if (!dev || count + 1 > sizeof str)
> > +	if (!dev || !dev->brightness || count + 1 > sizeof str)
> >  		return_VALUE(-EINVAL);
> >
> >  	if (copy_from_user(str, buffer, count))
> 
> Is it this http://bugzilla.kernel.org/show_bug.cgi?id=5571?

Yup, sorry, didn't realize a bug had been opened. I submitted this patch
to the list back in September and never heard back.

Thanks,
Nish


-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
Register for a JBoss Training Course.  Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click