From: Greg Kroah-Hartman <gregkh@suse.de>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, linux-usb-devel@lists.sourceforge.net
Subject: [patch 21/22] USB: delete the nokia_dku2 driver
Date: Thu, 17 Nov 2005 09:48:13 -0800 [thread overview]
Message-ID: <20051117174813.GW11174@kroah.com> (raw)
In-Reply-To: <20051117174609.GA11174@kroah.com>
[-- Attachment #1: usb-delete-nokia_dku2.patch --]
[-- Type: text/plain, Size: 5605 bytes --]
From: Greg Kroah-Hartman <gregkh@suse.de>
It was causing too many problems, and this is not the proper type of
driver for this device.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/usb/serial/Kconfig | 9 --
drivers/usb/serial/Makefile | 1
drivers/usb/serial/nokia_dku2.c | 142 ----------------------------------------
3 files changed, 152 deletions(-)
--- usb-2.6.orig/drivers/usb/serial/Kconfig
+++ usb-2.6/drivers/usb/serial/Kconfig
@@ -394,15 +394,6 @@ config USB_SERIAL_MCT_U232
To compile this driver as a module, choose M here: the
module will be called mct_u232.
-config USB_SERIAL_NOKIA_DKU2
- tristate "USB Nokia DKU2 Driver"
- depends on USB_SERIAL
- help
- Say Y here if you want to use a Nokia DKU2 device.
-
- To compile this driver as a module, choose M here: the
- module will be called nokia_dku2.
-
config USB_SERIAL_PL2303
tristate "USB Prolific 2303 Single Port Serial Driver"
depends on USB_SERIAL
--- usb-2.6.orig/drivers/usb/serial/Makefile
+++ usb-2.6/drivers/usb/serial/Makefile
@@ -31,7 +31,6 @@ obj-$(CONFIG_USB_SERIAL_KEYSPAN_PDA) +=
obj-$(CONFIG_USB_SERIAL_KLSI) += kl5kusb105.o
obj-$(CONFIG_USB_SERIAL_KOBIL_SCT) += kobil_sct.o
obj-$(CONFIG_USB_SERIAL_MCT_U232) += mct_u232.o
-obj-$(CONFIG_USB_SERIAL_NOKIA_DKU2) += nokia_dku2.o
obj-$(CONFIG_USB_SERIAL_OMNINET) += omninet.o
obj-$(CONFIG_USB_SERIAL_OPTION) += option.o
obj-$(CONFIG_USB_SERIAL_PL2303) += pl2303.o
--- usb-2.6.orig/drivers/usb/serial/nokia_dku2.c
+++ /dev/null
@@ -1,142 +0,0 @@
-/*
- * Nokia DKU2 USB driver
- *
- * Copyright (C) 2004
- * Author: C Kemp
- *
- * This program is largely derived from work by the linux-usb group
- * and associated source files. Please see the usb/serial files for
- * individual credits and copyrights.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * 20.09.2005 - Matthias Blaesing <matthias.blaesing@rwth-aachen.de>
- * Added short name to device structure to make driver load into kernel 2.6.13
- *
- * 20.09.2005 - Matthias Blaesing <matthias.blaesing@rwth-aachen.de>
- * Added usb_deregister to exit code - to allow remove and reinsert of module
- */
-
-
-#include <linux/config.h>
-#include <linux/kernel.h>
-#include <linux/errno.h>
-#include <linux/init.h>
-#include <linux/slab.h>
-#include <linux/tty.h>
-#include <linux/tty_driver.h>
-#include <linux/tty_flip.h>
-#include <linux/module.h>
-#include <linux/usb.h>
-#include "usb-serial.h"
-
-
-#define NOKIA_VENDOR_ID 0x0421
-#define NOKIA7600_PRODUCT_ID 0x0400
-#define NOKIA6230_PRODUCT_ID 0x040f
-#define NOKIA6170_PRODUCT_ID 0x0416
-#define NOKIA6670_PRODUCT_ID 0x041d
-#define NOKIA6680_PRODUCT_ID 0x041e
-#define NOKIA6230i_PRODUCT_ID 0x0428
-
-#define NOKIA_AT_PORT 0x82
-#define NOKIA_FBUS_PORT 0x86
-
-/*
- * Version Information
- */
-#define DRIVER_VERSION "v0.2"
-#define DRIVER_AUTHOR "C Kemp"
-#define DRIVER_DESC "Nokia DKU2 Driver"
-
-static struct usb_device_id id_table [] = {
- { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA7600_PRODUCT_ID) },
- { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6230_PRODUCT_ID) },
- { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6170_PRODUCT_ID) },
- { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6670_PRODUCT_ID) },
- { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6680_PRODUCT_ID) },
- { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6230i_PRODUCT_ID) },
- { } /* Terminating entry */
-};
-MODULE_DEVICE_TABLE(usb, id_table);
-
-/* The only thing which makes this device different from a generic
- * device is that we have to set an alternative configuration to make
- * the relevant endpoints available. In 2.6 this is really easy... */
-static int nokia_probe(struct usb_serial *serial,
- const struct usb_device_id *id)
-{
- int retval = -ENODEV;
-
- if (serial->interface->altsetting[0].endpoint[0].desc.bEndpointAddress == NOKIA_AT_PORT) {
- /* the AT port */
- dev_info(&serial->dev->dev, "Nokia AT Port:\n");
- retval = 0;
- } else if (serial->interface->num_altsetting == 2 &&
- serial->interface->altsetting[1].endpoint[0].desc.bEndpointAddress == NOKIA_FBUS_PORT) {
- /* the FBUS port */
- dev_info(&serial->dev->dev, "Nokia FBUS Port:\n");
- usb_set_interface(serial->dev, 10, 1);
- retval = 0;
- }
-
- return retval;
-}
-
-static struct usb_driver nokia_driver = {
- .owner = THIS_MODULE,
- .name = "nokia_dku2",
- .probe = usb_serial_probe,
- .disconnect = usb_serial_disconnect,
- .id_table = id_table,
-};
-
-static struct usb_serial_driver nokia_serial_driver = {
- .driver = {
- .owner = THIS_MODULE,
- .name = "nokia_dku2",
- },
- .description = "Nokia 7600/6230(i)/6170/66x0 DKU2 driver",
- .id_table = id_table,
- .num_interrupt_in = 1,
- .num_bulk_in = 1,
- .num_bulk_out = 1,
- .num_ports = 1,
- .probe = nokia_probe,
-};
-
-static int __init nokia_init(void)
-{
- int retval;
-
- retval = usb_serial_register(&nokia_serial_driver);
- if (retval)
- return retval;
-
- retval = usb_register(&nokia_driver);
- if (retval) {
- usb_serial_deregister(&nokia_serial_driver);
- return retval;
- }
-
- info(DRIVER_VERSION " " DRIVER_AUTHOR);
- info(DRIVER_DESC);
-
- return retval;
-}
-
-static void __exit nokia_exit(void)
-{
- usb_deregister(&nokia_driver);
- usb_serial_deregister(&nokia_serial_driver);
-}
-
-module_init(nokia_init);
-module_exit(nokia_exit);
-
-MODULE_AUTHOR(DRIVER_AUTHOR);
-MODULE_DESCRIPTION(DRIVER_DESC);
-MODULE_LICENSE("GPL");
--
next prev parent reply other threads:[~2005-11-17 18:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20051117174227.007572000@press.kroah.org>
2005-11-17 17:46 ` [patch 00/22] USB patches for 2.6.15-rc1 Greg Kroah-Hartman
2005-11-17 17:46 ` [patch 01/22] USB: fix build breakage in dummy_hcd.c Greg Kroah-Hartman
2005-11-17 17:46 ` [patch 02/22] USB Serial: rename ChangeLog.old Greg Kroah-Hartman
2005-11-17 17:46 ` [patch 03/22] USB: add new wacom devices to usb hid-core list Greg Kroah-Hartman
2005-11-17 17:46 ` [patch 06/22] USB: Delete leftovers from bluetty driver Greg Kroah-Hartman
2005-11-17 17:46 ` [patch 05/22] USB: fix 'unused variable' warning Greg Kroah-Hartman
2005-11-17 17:46 ` [patch 04/22] USB: wacom tablet driver update Greg Kroah-Hartman
2005-11-17 17:47 ` [patch 08/22] USB: usbdevfs_ioctl 32bit fix Greg Kroah-Hartman
2005-11-17 17:47 ` [patch 07/22] usbfs: usbfs_dir_inode_operations cleanup Greg Kroah-Hartman
2005-11-17 17:47 ` [patch 09/22] USB: kill unneccessary usb-storage blacklist entries Greg Kroah-Hartman
2005-11-17 17:47 ` [patch 10/22] USB: cp2101.c: Jablotron usb serial interface identification Greg Kroah-Hartman
2005-11-17 17:47 ` [patch 11/22] USB: onetouch doesn't suspend yet Greg Kroah-Hartman
2005-11-17 17:47 ` [patch 12/22] USB: pl2303: adds new IDs Greg Kroah-Hartman
2005-11-17 17:47 ` [patch 13/22] USB: pl2303: updates pl2303_update_line_status() Greg Kroah-Hartman
2005-11-17 17:47 ` [patch 14/22] USB: Adapt microtek driver to new scsi features Greg Kroah-Hartman
2005-11-17 17:47 ` [patch 16/22] USB: fix race in kaweth disconnect Greg Kroah-Hartman
2005-11-17 17:47 ` [patch 17/22] usb devio warning fix Greg Kroah-Hartman
2005-11-17 17:47 ` [patch 18/22] USB: Maxtor OneTouch button support for older drives Greg Kroah-Hartman
2005-11-17 17:47 ` [patch 19/22] USB: OHCI lh7a404 platform device conversion fixup Greg Kroah-Hartman
2005-11-17 17:48 ` [patch 15/22] usb-storage: Fix detection of kodak flash readers in shuttle_usbat driver Greg Kroah-Hartman
2005-11-17 17:48 ` [patch 20/22] USB: move CONFIG_USB_DEBUG checks into the Makefile Greg Kroah-Hartman
2005-11-17 17:48 ` Greg Kroah-Hartman
2005-11-17 17:48 ` Greg Kroah-Hartman [this message]
2005-11-17 17:48 ` [patch 22/22] USB: add the anydata usb-serial driver Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051117174813.GW11174@kroah.com \
--to=gregkh@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.