From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Vitaly Bordug <vbordug@ru.mvista.com>, Paul Mackerras <paulus@samba.org>
Cc: linuxppc-embedded list <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH] ppc32: 8xx board-specific platform stuff for fs_enet
Date: Fri, 18 Nov 2005 07:08:45 -0200 [thread overview]
Message-ID: <20051118090845.GB12765@logos.cnet> (raw)
In-Reply-To: <437DE07E.6080005@ru.mvista.com>
On Fri, Nov 18, 2005 at 05:09:02PM +0300, Vitaly Bordug wrote:
> Marcelo,
> Thanks for review, will fix.
>
> Guess the proper place for setbits/clrbits should be asm-ppc/io.h?
Yes, think so.
Paul, you're OK with the following definitions on asm-ppc/io.h?
+/* access ports */
+#define setbits32(_addr, _v) out_be32(&(_addr), in_be32(&(_addr)) | (_v))
+#define clrbits32(_addr, _v) out_be32(&(_addr), in_be32(&(_addr)) & ~(_v))
+
+#define setbits16(_addr, _v) out_be16(&(_addr), in_be16(&(_addr)) | (_v))
+#define clrbits16(_addr, _v) out_be16(&(_addr), in_be16(&(_addr)) & ~(_v))
next prev parent reply other threads:[~2005-11-18 14:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-16 12:04 [PATCH] ppc32: 8xx board-specific platform stuff for fs_enet Vitaly Bordug
2005-11-17 13:58 ` Marcelo Tosatti
2005-11-18 14:09 ` Vitaly Bordug
2005-11-18 9:08 ` Marcelo Tosatti [this message]
2005-11-23 2:40 ` Paul Mackerras
2005-11-23 9:11 ` Marcelo Tosatti
2005-11-23 16:05 ` Kumar Gala
2005-11-23 12:00 ` Marcelo Tosatti
2005-11-23 18:25 ` 'Aristeu Sergio Rozanski Filho'
2005-11-23 20:18 ` Dan Malek
2005-11-23 15:39 ` Marcelo Tosatti
2005-11-30 7:08 ` Kumar Gala
2005-12-01 12:17 ` Marcelo Tosatti
2005-12-01 14:15 ` Dan Malek
2005-12-01 15:13 ` Kumar Gala
2005-11-23 16:14 ` Vitaly Bordug
2005-11-17 14:07 ` Marcelo Tosatti
2005-11-18 14:11 ` Vitaly Bordug
2005-11-18 9:05 ` Marcelo Tosatti
-- strict thread matches above, loose matches on Subject: below --
2005-11-18 16:19 Vitaly Bordug
2005-11-23 8:34 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051118090845.GB12765@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=paulus@samba.org \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.