From: Thomas Graf <tgraf@suug.ch>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: yoshfuji@linux-ipv6.org, yanzheng@21cn.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [DEBUG INFO]IPv6: sleeping function called from invalid context.
Date: Sat, 19 Nov 2005 22:04:11 +0100 [thread overview]
Message-ID: <20051119210411.GE20395@postel.suug.ch> (raw)
In-Reply-To: <E1EdRCZ-0007uy-00@gondolin.me.apana.org.au>
* Herbert Xu <herbert@gondor.apana.org.au> 2005-11-19 22:48
> Thomas Graf <tgraf@suug.ch> wrote:
> >
> > I did. I think it was right, why would an allocation be necessary on
> > the second call to inet6_dump_fib()? The walker allocated in process
> > context on the first call should be reused from cb->args[0].
>
> Continued dumps are always called under spin lock (see netlink_dump).
> So we need to use GFP_ATOMIC in dumpers.
The continued dumps wouldn't be the problem, the walker is allocated
on the initial dump call. It was a mistake though, nlk->cb_lock spin
lock is always held for cb->dump() even though it should only be
required during the nlk->cb != NULL check. netlink_dump_start()
guarantees to only allow one dumper per socket at a time.
next prev parent reply other threads:[~2005-11-19 21:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-18 0:44 [DEBUG INFO]IPv6: sleeping function called from invalid context Yan Zheng
2005-11-18 0:47 ` YOSHIFUJI Hideaki / 吉藤英明
2005-11-18 12:35 ` Thomas Graf
2005-11-19 11:48 ` Herbert Xu
2005-11-19 21:04 ` Thomas Graf [this message]
2005-11-19 22:38 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051119210411.GE20395@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yanzheng@21cn.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.