All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: gregkh@suse.de, Thomas Winischhofer <thomas@winischhofer.net>
Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/usb/misc/sisusbvga/sisusb.c: remove dead code
Date: Mon, 21 Nov 2005 00:22:39 +0100	[thread overview]
Message-ID: <20051120232239.GI16060@stusta.de> (raw)

The Coverity checker found this obviously dead code.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/usb/misc/sisusbvga/sisusb.c |    6 ------
 1 file changed, 6 deletions(-)

--- linux-2.6.15-rc1-mm2-full/drivers/usb/misc/sisusbvga/sisusb.c.old	2005-11-20 22:56:41.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/drivers/usb/misc/sisusbvga/sisusb.c	2005-11-20 22:58:22.000000000 +0100
@@ -861,13 +861,10 @@
 
 	while (length) {
 
 	    switch (length) {
 
-		case 0:
-			return ret;
-
 		case 1:
 			if (userbuffer) {
 				if (get_user(swap8, (u8 __user *)userbuffer))
 					return -EFAULT;
 			} else
@@ -1219,13 +1216,10 @@
 
 	while (length) {
 
 	    switch (length) {
 
-		case 0:
-			return ret;
-
 		case 1:
 
 			ret |= sisusb_read_memio_byte(sisusb, SISUSB_TYPE_MEM,
 								addr, &buf[0]);
 			if (!ret) {


             reply	other threads:[~2005-11-20 23:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-20 23:22 Adrian Bunk [this message]
2005-11-23 19:02 ` [2.6 patch] drivers/usb/misc/sisusbvga/sisusb.c: remove dead code Greg KH
2005-11-23 20:31   ` Adrian Bunk
2005-11-28 20:52     ` Greg KH
2005-11-29 10:25       ` Thomas Winischhofer
2005-11-29 13:01       ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051120232239.GI16060@stusta.de \
    --to=bunk@stusta.de \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=thomas@winischhofer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.