From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Feustel <dfeustel@verizon.net>
Subject: Re: USB virt 2.6 split driver patch series
Date: Mon, 21 Nov 2005 09:29:57 -0500
Message-ID: <200511210929.57642.dfeustel@verizon.net>
References: <1132579104.31295.110.camel@localhost.localdomain>
	<20051121134940.GA25045@snarc.org>
	<1132581661.31295.134.camel@localhost.localdomain>
Reply-To: dfeustel@mindspring.com
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-reply-to: <1132581661.31295.134.camel@localhost.localdomain>
Content-disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
Cc: harry <harry@hebutterworth.freeserve.co.uk>, Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk>
List-Id: xen-devel@lists.xenproject.org

On Monday 21 November 2005 09:01, harry wrote:
> On Mon, 2005-11-21 at 14:49 +0100, Vincent Hanquez wrote:
> > On Mon, Nov 21, 2005 at 01:18:24PM +0000, harry wrote:
> > > o - I've reformatted all the code to the kernel coding style using
> > > Lindent and not attempted to improve it after that.  Some of the
> > > formatting needs to be improved.
> > 
> > some ? this is totally _not_ linux kernel coding style.
> > please have a look at Documentation/CodingStyle and kill anonymous
> > inline functions (braces in middle of functions).
> > 
> 
> I have read  Documentation/CodingStyle quite carefully and there is no 
> mention of using braces inside functions.  I'm used to using braces to
> define minimal scopes for local variables which makes the code easier to
> read by minimising the number of variables you need to keep track of
> when reading it and by declaring variables closer to where they are used
> so it is easier to verify that they have been correctly initialised.
> 
> Is this really banned?

I thought braces defined code blocks, not internal functions.
Without a label the code can be invoked only inline.

Dave Feustel 
> Harry.
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 

-- 
Switch to Secure OpenBSD with a KDE desktop!!!
NOW with Virtual PC OS support via QEMU and
Beowulf clustering using PETSc and MPICH2!