From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Hugh Dickins <hugh@veritas.com>
Cc: Takashi Iwai <tiwai@suse.de>, Lee Revell <rlrevell@joe-job.com>,
Miles Lane <miles.lane@gmail.com>, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: 2.6.15-rc1-mm2 -- Bad page state at free_hot_cold_page (in process 'aplay', page c18eef30)
Date: Mon, 21 Nov 2005 15:52:39 +0000 [thread overview]
Message-ID: <20051121155239.GC21032@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.61.0511211507160.15988@goblin.wat.veritas.com>
On Mon, Nov 21, 2005 at 03:46:50PM +0000, Hugh Dickins wrote:
> So another of my patches in -rc1-mm2 made the PageCompound technique
> available always, no longer under #ifdef CONFIG_HUGETLB_PAGE: so that
> get_page and put_page on the later constituents of the high-order
> page get redirected to the first one, and it should work okay again.
>
> Except that I'd missed that you actually have to choose to have your
> high-order pages supplied as compound pages, by passing __GFP_COMP.
> Since I wasn't passing that, they still weren't allocated as compound
> pages, so were still being freed too soon - and the PG_reserved flag
> found while freeing gave rise to the "Bad page state" messages seen.
Does this mean that in arch/arm/mm/consistent.c, we should also set
__GFP_COMP ? Should we be doing that today?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-11-21 15:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-20 6:56 2.6.15-rc1-mm2 -- Bad page state at free_hot_cold_page (in process 'aplay', page c18eef30) Miles Lane
2005-11-20 8:05 ` Hugh Dickins
2005-11-20 18:14 ` Lee Revell
2005-11-20 18:14 ` Lee Revell
2005-11-20 19:35 ` Hugh Dickins
2005-11-21 6:59 ` Miles Lane
2005-11-21 6:59 ` Miles Lane
2005-11-21 11:52 ` Takashi Iwai
2005-11-21 15:46 ` Hugh Dickins
2005-11-21 15:52 ` Russell King [this message]
2005-11-21 16:51 ` Hugh Dickins
2005-11-21 16:51 ` Hugh Dickins
2005-11-21 16:17 ` Takashi Iwai
2005-11-21 16:25 ` Russell King
2005-11-21 16:41 ` Takashi Iwai
2005-11-21 17:09 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051121155239.GC21032@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=alsa-devel@lists.sourceforge.net \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miles.lane@gmail.com \
--cc=rlrevell@joe-job.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.