From: Con Kolivas <kernel@kolivas.org>
To: "Daniel Marjamäki" <daniel.marjamaki@comhem.se>
Cc: linux-kernel@vger.kernel.org, 7eggert@gmx.de, nish.aravamudan@gmail.com
Subject: Re: I made a patch and would like feedback/testers (drivers/cdrom/aztcd.c)
Date: Mon, 21 Nov 2005 19:19:11 +1100 [thread overview]
Message-ID: <200511211919.11429.kernel@kolivas.org> (raw)
In-Reply-To: <438180C0.2030503@comhem.se>
On Mon, 21 Nov 2005 19:09, Daniel Marjamäki wrote:
> Bodo Eggert wrote:
> > Daniel Marjamäki <daniel.marjamaki@comhem.se> wrote:
> >>- aztTimeOutCount = 0;
> >>+ aztTimeOut = jiffies + 2;
> >
> > Different timeout based on HZ seems wrong.
>
> Yes, but..
>
> If I'd say "HZ/100", then all systems that uses my driver must have
> HZ>=200.
>
> The way I do it:
> All systems will give me a delay for at least a few ms.
> I get the shortest timeout possible on each computer.
Convention in the kernel would be
aztTimeOut = HZ / 100 ? : 1;
to be at least one tick (works for HZ even below 100) and is at least 10ms. If
you wanted 2 ms then use
aztTimeOut = HZ / 500 ? : 1;
which would give you at least 2ms
Cheers,
Con
next prev parent reply other threads:[~2005-11-21 8:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5aZsv-3CJ-17@gated-at.bofh.it>
2005-11-20 20:58 ` I made a patch and would like feedback/testers (drivers/cdrom/aztcd.c) Bodo Eggert
2005-11-20 21:07 ` Nish Aravamudan
2005-11-21 8:09 ` Daniel Marjamäki
2005-11-21 8:19 ` Con Kolivas [this message]
2005-11-21 8:42 ` Daniel Marjamäki
2005-11-21 9:11 ` Con Kolivas
2005-11-21 10:47 ` Nick Piggin
2005-11-21 15:08 ` Nish Aravamudan
2005-11-21 16:33 ` Bodo Eggert
2005-11-20 15:29 Daniel Marjamäki
2005-11-20 15:38 ` Arjan van de Ven
2005-11-20 17:15 ` Thomas Gleixner
2005-11-20 21:04 ` Nish Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200511211919.11429.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=7eggert@gmx.de \
--cc=daniel.marjamaki@comhem.se \
--cc=linux-kernel@vger.kernel.org \
--cc=nish.aravamudan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.