From: William Lee Irwin III <wli@holomorphy.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@osdl.org>, Takashi Iwai <tiwai@suse.de>,
Russell King <rmk+lkml@arm.linux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Linus Torvalds <torvalds@osdl.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Dave Airlie <airlied@gmail.com>,
linux-kernel@vger.kernel.org, alsa-devel@lists.sourceforge.net
Subject: Re: [PATCH 12/11] unpaged: fix sound Bad page states
Date: Mon, 21 Nov 2005 13:57:10 -0800 [thread overview]
Message-ID: <20051121215710.GR6916@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0511211801070.17464@goblin.wat.veritas.com>
On Mon, Nov 21, 2005 at 06:12:38PM +0000, Hugh Dickins wrote:
> Earlier I unifdefed PageCompound, so that snd_pcm_mmap_control_nopage
> and others can give out a 0-order component of a higher-order page,
> which won't be mistakenly freed when zap_pte_range unmaps it. But
> many Bad page states reported a PG_reserved was freed after all: I had
> missed that we need to say __GFP_COMP to get compound page behaviour.
> Some of these higher-order pages are allocated by snd_malloc_pages, some
> by snd_malloc_dev_pages; or if SBUS, by sbus_alloc_consistent - but that
> has no gfp arg, so add __GFP_COMP into its sparc32/64 implementations.
> I'm still rather puzzled that DRM seems not to need a similar change.
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
Acked-by: William Irwin <wli@holomorphy.com>
-- wli
prev parent reply other threads:[~2005-11-21 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 18:12 [PATCH 12/11] unpaged: fix sound Bad page states Hugh Dickins
2005-11-21 20:41 ` Andrew Morton
2005-11-21 20:41 ` Andrew Morton
2005-11-21 22:40 ` Hugh Dickins
2005-11-21 21:57 ` William Lee Irwin III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051121215710.GR6916@holomorphy.com \
--to=wli@holomorphy.com \
--cc=airlied@gmail.com \
--cc=akpm@osdl.org \
--cc=alsa-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=tiwai@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.