All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: Still some serial console corruption on sunsab
Date: Wed, 23 Nov 2005 06:30:03 +0000	[thread overview]
Message-ID: <20051122.223003.82991428.davem@davemloft.net> (raw)
In-Reply-To: <Pine.SOC.4.61.0510121223230.29862@math.ut.ee>


I wonder if we're setting the CEC and TEC timeouts too short.

Can you give this patch a spin?  There are some other things
we can try if this still doesn't fix things.

Thanks.

diff --git a/drivers/serial/sunsab.c b/drivers/serial/sunsab.c
index ba9381f..7665a9d 100644
--- a/drivers/serial/sunsab.c
+++ b/drivers/serial/sunsab.c
@@ -93,7 +93,7 @@ static char *sab82532_version[16] = {
 
 static __inline__ void sunsab_tec_wait(struct uart_sunsab_port *up)
 {
-	int timeout = up->tec_timeout;
+	int timeout = SAB82532_MAX_TEC_TIMEOUT;
 
 	while ((readb(&up->regs->r.star) & SAB82532_STAR_TEC) && --timeout)
 		udelay(1);
@@ -101,7 +101,7 @@ static __inline__ void sunsab_tec_wait(s
 
 static __inline__ void sunsab_cec_wait(struct uart_sunsab_port *up)
 {
-	int timeout = up->cec_timeout;
+	int timeout = SAB82532_MAX_CEC_TIMEOUT;
 
 	while ((readb(&up->regs->r.star) & SAB82532_STAR_CEC) && --timeout)
 		udelay(1);

  parent reply	other threads:[~2005-11-23  6:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-12  9:28 Still some serial console corruption on sunsab Meelis Roos
2005-10-12 11:20 ` Marc Zyngier
2005-10-14 22:35 ` David S. Miller
2005-11-04 20:16 ` David S. Miller
2005-11-05  9:42 ` Meelis Roos
2005-11-10 21:01 ` David S. Miller
2005-11-10 21:08 ` Meelis Roos
2005-11-18  8:45 ` Meelis Roos
2005-11-18  8:50 ` David S. Miller
2005-11-23  6:30 ` David S. Miller [this message]
2005-11-23  7:12 ` Meelis Roos
2005-11-23  7:43 ` David S. Miller
2005-11-23  8:26 ` Meelis Roos
2005-11-23  8:58 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051122.223003.82991428.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.