From: Matthew Wilcox <matthew@wil.cx>
To: Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Russell King <rmk@arm.linux.org.uk>,
Ian Molton <spyro@f2s.com>, David Howells <dhowells@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/5] Ensure NO_IRQ is appropriately defined on all architectures
Date: Tue, 22 Nov 2005 09:43:46 -0700 [thread overview]
Message-ID: <20051122164345.GM1598@parisc-linux.org> (raw)
In-Reply-To: <20051122142755.GA28239@infradead.org>
On Tue, Nov 22, 2005 at 02:27:55PM +0000, Christoph Hellwig wrote:
> On Tue, Nov 22, 2005 at 12:19:06AM -0500, Matthew Wilcox wrote:
> > Add a default definition of NO_IRQ to <linux/hardirq.h> and make the
> > definition in <asm/hardirq.h> uniform across all architectures which
> > define it.
>
> Please put the definition into <asm/irq.h> and <linux/interrupt.h>,
> hardirq.h is rather misnamed and about the internal irq/softirq/preempt
> mask mechanisms.
Either you're wrong or I'm confused. I don't see the include path which
necessarily drags asm/irq.h in from linux/interrupt.h. There's a
linux/interrupt.h -> linux/hardirq.h -> asm/hardirq.h path, but not all
asm/hardirq.h files drag in asm/irq.h. Look at sparc64 or alpha for
examples of that.
Personally, I'd like to see asm/hardirq.h go away and move all its
contents into asm/irq.h. And I'd like to see asm/irq.h included
explicitly from linux/interrupt.h. And I'd like to see drivers stop
including asm/irq.h.
While I'm dreaming, I'd like a pony.
next prev parent reply other threads:[~2005-11-22 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-22 5:19 [PATCH 2/5] Ensure NO_IRQ is appropriately defined on all architectures Matthew Wilcox
2005-11-22 14:20 ` Matthew Wilcox
2005-11-22 14:27 ` Christoph Hellwig
2005-11-22 16:43 ` Matthew Wilcox [this message]
2005-12-06 17:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051122164345.GM1598@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rmk@arm.linux.org.uk \
--cc=spyro@f2s.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.