From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Hanquez Subject: Re: USB virt 2.6 split driver patch series Date: Tue, 22 Nov 2005 21:27:00 +0100 Message-ID: <20051122202659.GA31571@snarc.org> References: <1132586050.31295.145.camel@localhost.localdomain> <5d7aca950511210727i741148efl71f025577680d994@mail.gmail.com> <1132587554.31295.154.camel@localhost.localdomain> <5d7aca950511210902j5002bbfdxe52b1a32517d6c8b@mail.gmail.com> <1132593451.31295.171.camel@localhost.localdomain> <5d7aca950511211759i63ed353al8f95ea411bbd49ff@mail.gmail.com> <5d7aca950511211800j9799a2dy3186ef4133213417@mail.gmail.com> <1132655069.5956.5.camel@localhost.localdomain> <20051122110710.GA29624@snarc.org> <43833B4E.8070502@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <43833B4E.8070502@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Anthony Liguori Cc: xen-devel@lists.xensource.com, NAHieu , harry , Vincent Hanquez List-Id: xen-devel@lists.xenproject.org On Tue, Nov 22, 2005 at 09:37:50AM -0600, Anthony Liguori wrote: > Harry's right, it's not allowed by the C standard. still this is common accepted practice is kernel code ... (no glibc included/linked, gcc specific) > FWIW, I don't think it's all that common to use underscores to denote > functions as private when you can just mark them static. grep "__[a-z]" | grep "EXPORT" in linux kernel source you'll be surprise. most kernels-code reason to provide both function (__fctname and fctname) is: - one is lock free, the other lock what is necessary. - one test some conditions, the other doesn't and probably some others reasons .. Cheers, -- Vincent Hanquez