All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jordan Crouse" <jordan.crouse@amd.com>
To: "Dan Malek" <dan@embeddedalley.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: Fix board type in db1x00
Date: Tue, 22 Nov 2005 18:18:45 -0700	[thread overview]
Message-ID: <20051123011845.GA6502@cosmic.amd.com> (raw)
In-Reply-To: <968d9f47767cad14f9924abc1d07972b@embeddedalley.com>

On 22/11/05 19:24 -0500, Dan Malek wrote:
> 
> On Nov 22, 2005, at 7:15 PM, Jordan Crouse wrote:
> 
> >....  That means either the mess goes in here or it goes
> >in asm-mips/mach-db1x00/db1x00.h,
> 
> You are already doing this for other things, like the BCSR
> differences with the db1550.  Why not put it all on one place?
> You could even generate out of the Kconfig process and
> not need it in any file. :-)  The problem is if you propagate
> stuff like this "...  because there isn't an include file ..." others
> will also take that attitude.  Someone has to start the
> process.  For something as generic as these boards, the
> next one should simply be an include file update, not the
> need to edit various source files as is necessary today.

I'll buy into the general idea, but I'll defer to Ralf to see if
he wants us to start inflicting this on the tree, or if he would
just prefer to let sleeping dogs lay.  One one hand, its nice to 
clean things up, but on the other hand, we're not making any more
DB boards :( so its doubtful the ugliness will grow much further then
this.

Thanks for your comments,
Jordan

-- 
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>

  reply	other threads:[~2005-11-23  1:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-22 22:15 [PATCH] Fix board type in db1x00 Jordan Crouse
2005-11-22 22:31 ` Dan Malek
2005-11-23  0:15   ` Jordan Crouse
2005-11-23  0:24     ` Dan Malek
2005-11-23  1:18       ` Jordan Crouse [this message]
2005-11-23  6:31   ` [PATCH] " Matej Kupljen
2005-11-23 14:39     ` Dan Malek
2005-11-29 16:51   ` Ralf Baechle
2005-11-30  8:35     ` Matej Kupljen
2005-11-30 11:23       ` Ralf Baechle
2005-11-30 15:29       ` Jordan Crouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051123011845.GA6502@cosmic.amd.com \
    --to=jordan.crouse@amd.com \
    --cc=dan@embeddedalley.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.