From: Matthew Wilcox <matthew@wil.cx>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: linux-scsi@vger.kernel.org,
'James Bottomley' <James.Bottomley@SteelEye.com>
Subject: Re: [patch] kill duplicated scsi_cmnd->pid
Date: Wed, 23 Nov 2005 18:02:21 -0700 [thread overview]
Message-ID: <20051124010221.GY1598@parisc-linux.org> (raw)
In-Reply-To: <200511240100.jAO10Vg31538@unix-os.sc.intel.com>
On Wed, Nov 23, 2005 at 05:00:31PM -0800, Chen, Kenneth W wrote:
> Kill scsi_cmnd->pid, since it is exactly the same as ->serial_number.
> No need to use two variables for the same thing. (it's easier to
> remove pid since usage in printk is a lot less compare to serial_number,
> only dc395x and tmscsim).
But serial_number makes much more sense than pid as a name, so it's
better to kill pid, even though it's a bigger patch.
next prev parent reply other threads:[~2005-11-24 1:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-24 1:00 [patch] kill duplicated scsi_cmnd->pid Chen, Kenneth W
2005-11-24 1:02 ` Matthew Wilcox [this message]
2005-11-24 1:05 ` Chen, Kenneth W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051124010221.GY1598@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@SteelEye.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.