All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: LKML Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [Q] is queue->hardsect_size respected?
Date: Thu, 24 Nov 2005 11:00:51 +0100	[thread overview]
Message-ID: <20051124100050.GD15804@suse.de> (raw)
In-Reply-To: <58cb370e0511230824j2585d755vdd9b6b780ed0fed3@mail.gmail.com>

On Wed, Nov 23 2005, Bartlomiej Zolnierkiewicz wrote:
> Hi,
> 
> I'm hacking on ide-cd.c and I've noticed that some old code
> (PIO handing for read fs requests) still supports unaligned access:

I think that can safely die, that code even predates me maintaining it.
It's a bug to receive a request that's not hardsector aligned. It used
to be a problem with eg hfs cds, since they use 512b sectors. But the
caching should take care of it for us, it's definitely not driver
business.

So rip it!

-- 
Jens Axboe


      reply	other threads:[~2005-11-24  9:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-23 16:24 [Q] is queue->hardsect_size respected? Bartlomiej Zolnierkiewicz
2005-11-24 10:00 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051124100050.GD15804@suse.de \
    --to=axboe@suse.de \
    --cc=bzolnier@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.