From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Vasily Averin <vvs@sw.ru>
Cc: linux-kernel@vger.kernel.org,
Konstantin Khorenko <khorenko@sw.ru>,
netdev@oss.sgi.com, Daniele Venzano <venza@brownhat.org>
Subject: Re: [PATCH 2.4] sis900: come alive after temporary memory shortage
Date: Sun, 27 Nov 2005 06:35:15 -0200 [thread overview]
Message-ID: <20051127083515.GA20701@logos.cnet> (raw)
In-Reply-To: <438829AF.8060101@sw.ru>
On Sat, Nov 26, 2005 at 12:23:59PM +0300, Vasily Averin wrote:
> Hello Marcelo,
>
> I would like to inform you that unfortunately the committed patch is wrong
> http://www.kernel.org/git/?p=linux/kernel/git/marcelo/linux-2.4.git;a=commit;h=ecf3337f76eaa94c5a771308d184dc248b74b725
>
> + int rx_work_limit =
> + (sis_priv->dirty_rx - sis_priv->cur_rx) % NUM_RX_DESC;
>
> when dirty_rx = cur_rx it computes limit=0, but should be NUM_RX_DESC
>
> Could you please drop the wrong patch and use a new one based on the version
> approved by Daniele Venzano and Jeff Garzik
> http://www.kernel.org/git/?p=linux/kernel/git/jgarzik/netdev-2.6.git;a=commitdiff_plain;h=7380a78a973a8109c13cb0e47617c456b6f6e1f5;hp=b2795f596932286ef12dc08857960d654f577405
Will do - thanks Vasily.
next prev parent reply other threads:[~2005-11-27 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-26 9:23 [PATCH 2.4] sis900: come alive after temporary memory shortage Vasily Averin
2005-11-27 8:35 ` Marcelo Tosatti [this message]
2005-11-27 8:35 ` Marcelo Tosatti
-- strict thread matches above, loose matches on Subject: below --
2005-11-26 9:23 Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051127083515.GA20701@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=khorenko@sw.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=venza@brownhat.org \
--cc=vvs@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.