All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Lucas <clucas@rotomalug.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ][PATCH] linux-2.6.15-rc2 apm_emu.c audit misc_register() ret.
Date: Mon, 28 Nov 2005 11:25:20 +0000	[thread overview]
Message-ID: <20051128112520.GA8272@rotomalug.org> (raw)
In-Reply-To: <34a7ae040511230009j20cff459r@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

Paolo Teti (paolo.teti@gmail.com) wrote:
> > Speaking of your patch, it shouldn't use KERN_WARNING and should (minor
> > nitpick) test for "< 0", not "!= 0".
> >
> >
> 
> Why?
> Looking at misc_register function the rule is
> 
> "A zero is returned on success and a negative errno code for failure."
> 
> So test for !=0 is also correct!!
> 
> Sorry probably because I have used Ccr instead of Cc I have also sent this patch
> to Benjamin Herrenschmidt ( the ppc APM manteiner) and now this patch
> is on the -mm
> tree as show below!
> 
> Sorry!!
 
You don't have to be sorry. It is about my patch Alexey say that.

I understand your reply Alexey. I would have prefered to know that in
July 2005 not in November 2005.

Have a nice day,

				- Christophe (clucas@rotomalug.org)


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2005-11-28 11:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-23  8:09 [KJ][PATCH] linux-2.6.15-rc2 apm_emu.c audit misc_register() ret. code Paolo Teti
2005-11-24  7:32 ` [KJ][PATCH] linux-2.6.15-rc2 apm_emu.c audit misc_register() ret Christophe Lucas
2005-11-24  8:02 ` Paolo Teti
2005-11-26 20:39 ` Alexey Dobriyan
2005-11-28 10:34 ` Paolo Teti
2005-11-28 11:25 ` Christophe Lucas [this message]
2005-11-28 12:53 ` Paolo Teti
  -- strict thread matches above, loose matches on Subject: below --
2005-11-22 18:07 [KJ] [PATCH] " Paolo Teti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051128112520.GA8272@rotomalug.org \
    --to=clucas@rotomalug.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.