All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim O'Callaghan <timo@dspsrv.com>
To: git@vger.kernel.org
Subject: Re: use binmode(STDOUT) in git-status
Date: Tue, 29 Nov 2005 11:05:50 +0100	[thread overview]
Message-ID: <20051129100550.GA2124@ELSAMSW37164> (raw)
In-Reply-To: <7vd5kkvd3q.fsf@assigned-by-dhcp.cox.net>

On Mon, Nov 28, 2005 at 10:31:05AM -0800, Junio C Hamano wrote:
> Alex Riesen <raa.lkml@gmail.com> writes:
> 
> > Activision's Perl generates CRLF unless STDOUT is binmoded, which is
> > inconsistent with other output of git-status.
> 
> I do not think this is a kind of patch that I should accept to
> apply to the generic part of the codepath, even if on sane
> platforms binmode() could be a no-op.
> 
> You should not have to say binmode() when you are emitting plain
> text (otherwise you have to say that everywhere which is
> madness).  I presume the Cygwin version uses Perl from Cygwin
> and would not have this problem?
> 
> If that is the case, maybe this patch should be maintained out
> of tree by the maintainer of Windows port of git that does _not_
> use Cygwin but ActiveState.
>

You could also check `perl -v` for the phrase "built for cygwin". I am not
sure how much of an issue this is though, because native windows support is
going to be a bit tricky without Cygwin as you also need (ba)sh, sed, grep,
etc.

Tim.

  reply	other threads:[~2005-11-29 10:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-28  7:34 use binmode(STDOUT) in git-status Alex Riesen
2005-11-28 15:55 ` H. Peter Anvin
2005-11-28 16:02   ` Johannes Schindelin
2005-11-28 16:08     ` H. Peter Anvin
2005-11-28 16:56       ` Johannes Schindelin
2005-11-29 22:12         ` Alex Riesen
2005-11-29 22:44           ` [OT] Activision (Re: use binmode(STDOUT) in git-status) Junio C Hamano
2005-11-29 23:56             ` Johannes Schindelin
2005-11-28 18:31 ` use binmode(STDOUT) in git-status Junio C Hamano
2005-11-29 10:05   ` Tim O'Callaghan [this message]
2005-11-29 11:44     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051129100550.GA2124@ELSAMSW37164 \
    --to=timo@dspsrv.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.