From: Magnus Damm <magnus@valinux.co.jp>
To: netdev@oss.sgi.com
Cc: Magnus Damm <magnus@valinux.co.jp>
Subject: [PATCH] i82596/CONFIG_APRICOT release_region() fix
Date: Wed, 30 Nov 2005 16:23:45 +0900 (JST) [thread overview]
Message-ID: <20051130072604.7030.49055.sendpatchset@cherry.local> (raw)
Fix release_region() in i82596 driver using CONFIG_APRICOT.
linux-2.6.15-rc3 configured with CONFIG_APRICOT=y calls release_region()
incorrectly if no hardware is found:
Trying to free nonexistent resource <00000000-00000010>
This patch sets up dev->base_addr before the label "out1" might be used.
Signed-off-by: Magnus Damm <magnus@valinux.co.jp>
---
82596.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.15-rc3/drivers/net/82596.c 2005-11-30 16:10:34.000000000 +0900
+++ linux-2.6.15-rc3-i82596_apricot_release_region/drivers/net/82596.c 2005-11-30 16:11:13.000000000 +0900
@@ -1203,6 +1203,9 @@
checksum += eth_addr[i];
}
+ dev->base_addr = ioaddr;
+ dev->irq = 10;
+
/* checksum is a multiple of 0x100, got this wrong first time
some machines have 0x100, some 0x200. The DOS driver doesn't
even bother with the checksum.
@@ -1215,8 +1218,6 @@
goto out1;
}
- dev->base_addr = ioaddr;
- dev->irq = 10;
}
#endif
dev->mem_start = (int)__get_free_pages(GFP_ATOMIC, 0);
reply other threads:[~2005-11-30 7:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051130072604.7030.49055.sendpatchset@cherry.local \
--to=magnus@valinux.co.jp \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.