From: Willy Tarreau <willy@w.ods.org>
To: David Gibson <david@gibson.dropbear.id.au>,
Andrew Morton <akpm@osdl.org>, Adam Litke <agl@us.ibm.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, marcelo.tosatti@cyclades.com
Subject: Re: Fix handling of ELF segments with zero filesize
Date: Thu, 1 Dec 2005 06:45:41 +0100 [thread overview]
Message-ID: <20051201054541.GA22097@alpha.home.local> (raw)
In-Reply-To: <20051201053641.GA11928@localhost.localdomain>
On Thu, Dec 01, 2005 at 04:36:41PM +1100, David Gibson wrote:
> On Thu, Dec 01, 2005 at 06:26:42AM +0100, Willy Tarreau wrote:
> > On Thu, Dec 01, 2005 at 11:20:49AM +1100, David Gibson wrote:
> > > Andrew, please apply
> > >
> > > mmap() returns -EINVAL if given a zero length, and thus elf_map() in
> > > binfmt_elf.c does likewise if it attempts to map a (page-aligned) ELF
> > > segment with zero filesize. Such a situation never arises with the
> > > default linker scripts, but there's nothing inherently wrong with
> > > zero-filesize (but non-zero memsize) ELF segments. Custom linker
> > > scripts can generate them, and the kernel should be able to map them;
> > > this patch makes it so.
> >
> > David, 2.4 has exactly the same code, do you see anything wrong with
> > applying this patch to 2.4 too ?
>
> Nothing that I can think of.
Thanks, I'm queueing it for -hf and will resend it to Marcelo if he
misses it.
Regards,
Willy
prev parent reply other threads:[~2005-12-01 5:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-01 0:20 Fix handling of ELF segments with zero filesize David Gibson
2005-12-01 0:26 ` H. Peter Anvin
2005-12-01 5:26 ` Willy Tarreau
2005-12-01 5:36 ` David Gibson
2005-12-01 5:45 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051201054541.GA22097@alpha.home.local \
--to=willy@w.ods.org \
--cc=agl@us.ibm.com \
--cc=akpm@osdl.org \
--cc=david@gibson.dropbear.id.au \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.