From: Olaf Hering <olh@suse.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: mchehab@brturbo.com.br, video4linux-list@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/media/video/: make code static
Date: Thu, 1 Dec 2005 20:46:37 +0100 [thread overview]
Message-ID: <20051201194637.GA2306@suse.de> (raw)
In-Reply-To: <20051120024432.GV16060@stusta.de>
On Sun, Nov 20, Adrian Bunk wrote:
> drivers/media/video/cx25840/cx25840-core.c | 4 ++--
> --- linux-2.6.15-rc1-mm2-full/drivers/media/video/cx25840/cx25840-core.c.old 2005-11-20 02:55:12.000000000 +0100
> +++ linux-2.6.15-rc1-mm2-full/drivers/media/video/cx25840/cx25840-core.c 2005-11-20 02:55:23.000000000 +0100
> @@ -714,7 +714,7 @@
>
> /* ----------------------------------------------------------------------- */
>
> -struct i2c_driver i2c_driver_cx25840;
> +static struct i2c_driver i2c_driver_cx25840;
>
> static int cx25840_detect_client(struct i2c_adapter *adapter, int address,
> int kind)
> @@ -807,7 +807,7 @@
>
> /* ----------------------------------------------------------------------- */
>
> -struct i2c_driver i2c_driver_cx25840 = {
> +static struct i2c_driver i2c_driver_cx25840 = {
> .name = "cx25840",
>
> .id = I2C_DRIVERID_CX25840,
Why does it exist twice? Once uninitalized, once intialized? Appearently
I miss the point. I also dont find the place where ->command is called.
There are other problems with this driver. If VIDIOC_S_STD gets passed
to cx25840_command, set_v4lstd will get a 64bit value as second arg. gcc
for ppc generates calls to __ucmpdi2, from libgcc.
Only a few archs implement this function inside the kernel. Maybe this
driver should become arm/fvr/h8300 only in 2.6.15?
--
short story of a lazy sysadmin:
alias appserv=wotan
prev parent reply other threads:[~2005-12-01 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-20 2:44 [2.6 patch] drivers/media/video/: make code static Adrian Bunk
2005-11-20 15:47 ` Mauro Carvalho Chehab
2005-12-01 19:46 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051201194637.GA2306@suse.de \
--to=olh@suse.de \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@brturbo.com.br \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.