All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Dinakar Guniguntala <dino@in.ibm.com>
Cc: linux-kernel@vger.kernel.org, david singleton <dsingleton@mvista.com>
Subject: Re: Perf degradation from -rt14 onwards
Date: Thu, 1 Dec 2005 22:21:05 +0100	[thread overview]
Message-ID: <20051201212105.GA25686@elte.hu> (raw)
In-Reply-To: <20051201204227.GA16035@in.ibm.com>


* Dinakar Guniguntala <dino@in.ibm.com> wrote:

> I was wondering why the following change was made from -rt14
> onwards.
> 
> 
> @@ -1634,7 +1531,7 @@ asmlinkage long sys_futex(u32 __user *ua
>                           int val3)
>  {
>         struct timespec t;
> -       unsigned long timeout = MAX_SCHEDULE_TIMEOUT;
> +       unsigned long timeout = 0;
> 
> This was introduced in patch-2.6.14-rt13-rf3 by David.
> 
> This seems to return spurious -ETIMEDOUT errors even in the non-robust 
> code and results in userspace (glibc) retrying several mutex 
> operations before it succeeds. I was chasing down a degradation of 
> performance of some testcases and was able to fix those by reverting 
> this change back.

nice catch! I've undone this change in my tree.

	Ingo

      parent reply	other threads:[~2005-12-01 21:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-01 20:42 Perf degradation from -rt14 onwards Dinakar Guniguntala
2005-12-01 20:59 ` David Singleton
2005-12-01 21:21 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051201212105.GA25686@elte.hu \
    --to=mingo@elte.hu \
    --cc=dino@in.ibm.com \
    --cc=dsingleton@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.