From: "David S. Miller" <davem@davemloft.net>
To: nickpiggin@yahoo.com.au
Cc: Linux-Kernel@vger.kernel.org, linux-mm@kvack.org,
paul.mckenney@us.ibm.com, wfg@mail.ustc.edu.cn
Subject: Re: [RFC] lockless radix tree readside
Date: Mon, 05 Dec 2005 19:11:53 -0800 (PST) [thread overview]
Message-ID: <20051205.191153.19905732.davem@davemloft.net> (raw)
In-Reply-To: <4394EC28.8050304@yahoo.com.au>
From: Nick Piggin <nickpiggin@yahoo.com.au>
Date: Tue, 06 Dec 2005 12:40:56 +1100
> I realise that radix-tree.c isn't a trivial bit of code so I don't
> expect reviews to be forthcoming, but if anyone had some spare time
> to glance over it that would be great.
I went over this a few times and didn't find any obvious
problems with the RCU aspect of this.
> Is my given detail of the implementation clear? Sufficient? Would
> diagrams be helpful?
If I were to suggest an ascii diagram for a comment, it would be
one which would show the height invariant this patch takes advantage
of.
Nice work.
WARNING: multiple messages have this Message-ID (diff)
From: "David S. Miller" <davem@davemloft.net>
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: nickpiggin@yahoo.com.au
Cc: Linux-Kernel@Vger.Kernel.ORG, linux-mm@kvack.org,
paul.mckenney@us.ibm.com, wfg@mail.ustc.edu.cn
Subject: Re: [RFC] lockless radix tree readside
Date: Mon, 05 Dec 2005 19:11:53 -0800 (PST)
Date: Tue, 06 Dec 2005 12:40:56 +1100 [thread overview]
Message-ID: <20051205.191153.19905732.davem@davemloft.net> (raw)
In-Reply-To: <4394EC28.8050304@yahoo.com.au>
> I realise that radix-tree.c isn't a trivial bit of code so I don't
> expect reviews to be forthcoming, but if anyone had some spare time
> to glance over it that would be great.
I went over this a few times and didn't find any obvious
problems with the RCU aspect of this.
> Is my given detail of the implementation clear? Sufficient? Would
> diagrams be helpful?
If I were to suggest an ascii diagram for a comment, it would be
one which would show the height invariant this patch takes advantage
of.
Nice work.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-12-06 3:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-06 1:40 [RFC] lockless radix tree readside Nick Piggin
2005-12-06 3:11 ` David S. Miller [this message]
2005-12-06 3:11 ` David S. Miller, Nick Piggin
2005-12-06 5:48 ` Nick Piggin
2005-12-06 5:48 ` Nick Piggin
2005-12-06 15:53 ` Joe Seigh
2005-12-06 22:36 ` Nick Piggin
2005-12-06 22:36 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051205.191153.19905732.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Linux-Kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
--cc=paul.mckenney@us.ibm.com \
--cc=wfg@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.