From: Nick Holloway <Nick.Holloway@pyrites.org.uk>
To: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: [PATCH 2.6.15-rc4 1/1] cpia: use vm_insert_page() instead of remap_pfn_range()
Date: Mon, 5 Dec 2005 15:27:58 +0000 [thread overview]
Message-ID: <20051205152758.GA29108@pyrites.org.uk> (raw)
Use vm_insert_page() instead of remap_pfn_range(), and remove
the PageReserved fiddling.
Signed-off-by: Nick Holloway <Nick.Holloway@pyrites.org.uk>
---
Although the cpia driver functioned correctly after printing out the
"incomplete pfn remapping" message, I thought I would have a go at the
trivial conversion'' as I have access to the hardware.
Driver has been tested with a parport CPIA camera (using "motion").
cpia.c | 22 ++++------------------
1 files changed, 4 insertions(+), 18 deletions(-)
--- linux-2.6.15-rc4/drivers/media/video/cpia.c~ 2005-12-03 10:04:33.000000000 +0000
+++ linux-2.6.15-rc4/drivers/media/video/cpia.c 2005-12-05 11:20:57.000000000 +0000
@@ -219,7 +219,6 @@ static void set_flicker(struct cam_param
static void *rvmalloc(unsigned long size)
{
void *mem;
- unsigned long adr;
size = PAGE_ALIGN(size);
mem = vmalloc_32(size);
@@ -227,29 +226,15 @@ static void *rvmalloc(unsigned long size
return NULL;
memset(mem, 0, size); /* Clear the ram out, no junk to the user */
- adr = (unsigned long) mem;
- while (size > 0) {
- SetPageReserved(vmalloc_to_page((void *)adr));
- adr += PAGE_SIZE;
- size -= PAGE_SIZE;
- }
return mem;
}
static void rvfree(void *mem, unsigned long size)
{
- unsigned long adr;
-
if (!mem)
return;
- adr = (unsigned long) mem;
- while ((long) size > 0) {
- ClearPageReserved(vmalloc_to_page((void *)adr));
- adr += PAGE_SIZE;
- size -= PAGE_SIZE;
- }
vfree(mem);
}
@@ -3753,7 +3738,8 @@ static int cpia_mmap(struct file *file,
struct video_device *dev = file->private_data;
unsigned long start = vma->vm_start;
unsigned long size = vma->vm_end - vma->vm_start;
- unsigned long page, pos;
+ unsigned long pos;
+ struct page* page;
struct cam_data *cam = dev->priv;
int retval;
@@ -3781,8 +3767,8 @@ static int cpia_mmap(struct file *file,
pos = (unsigned long)(cam->frame_buf);
while (size > 0) {
- page = vmalloc_to_pfn((void *)pos);
- if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) {
+ page = vmalloc_to_page((void *)pos);
+ if (vm_insert_page(vma, start, page)) {
up(&cam->busy_lock);
return -EAGAIN;
}
--
`O O' | Nick.Holloway@pyrites.org.uk
// ^ \\ | http://www.pyrites.org.uk/
next reply other threads:[~2005-12-05 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-05 15:27 Nick Holloway [this message]
2005-12-06 18:31 ` [PATCH 2.6.15-rc4 1/1] cpia: use vm_insert_page() instead of remap_pfn_range() Hugh Dickins
2005-12-06 20:35 ` Nick Holloway
2005-12-07 23:03 ` Mauro Carvalho Chehab
2005-12-06 19:10 ` Christoph Hellwig
2005-12-06 21:04 ` Nick Holloway
2005-12-06 22:20 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051205152758.GA29108@pyrites.org.uk \
--to=nick.holloway@pyrites.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.