2.6.15-rc5-mm1: USB_IP problems

[Adrian Bunk <bunk@stusta.de>]

On Sun, Dec 04, 2005 at 11:21:53PM -0800, Andrew Morton wrote:
>...
>  Subsystem trees
>...
> +gregkh-usb-usbip.patch
> 
>  USB tree updates
>...

Problems with this patch:
- USB_IP: no need for a "default N"
- USB_IP must be a tristate, because currently the illegal configurations 
  USB=m, USB_IP=y, USB_IP_{VHCI,STUB}=y are allowed
- compilation fails with USB_IP_VHCI=y, USB_IP_STUB=y:

<--  snip  -->

...
  LD      drivers/usb/ip/built-in.o
drivers/usb/ip/stub.o: In function `usbip_pack_pdu':
: multiple definition of `usbip_pack_pdu'
drivers/usb/ip/vhci-hcd.o:: first defined here
drivers/usb/ip/stub.o: In function `usbip_task_init':
: multiple definition of `usbip_task_init'
drivers/usb/ip/vhci-hcd.o:: first defined here
drivers/usb/ip/stub.o: In function `setreuse':
: multiple definition of `setreuse'
drivers/usb/ip/vhci-hcd.o:: first defined here
drivers/usb/ip/stub.o: In function `usbip_start_eh':
: multiple definition of `usbip_start_eh'
drivers/usb/ip/vhci-hcd.o:: first defined here
drivers/usb/ip/stub.o:(.data+0x0): multiple definition of 
`usbip_debug_flag'
drivers/usb/ip/vhci-hcd.o:(.data+0x0): first defined here
...
make[3]: *** [drivers/usb/ip/built-in.o] Error 1

<--  snip  -->


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed