From: Wu Fengguang <wfg@mail.ustc.edu.cn>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>,
Christoph Lameter <christoph@lameter.com>,
Rik van Riel <riel@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Nick Piggin <npiggin@suse.de>,
Wu Fengguang <wfg@mail.ustc.edu.cn>
Subject: [PATCH 08/16] mm: fine grained scan priority
Date: Wed, 07 Dec 2005 18:48:03 +0800 [thread overview]
Message-ID: <20051207105051.503626000@localhost.localdomain> (raw)
In-Reply-To: 20051207104755.177435000@localhost.localdomain
[-- Attachment #1: mm-fine-grained-scan-priority.patch --]
[-- Type: text/plain, Size: 3311 bytes --]
Limit max scan fraction to 1/64. The scan fractions will be
1/4096, 64x1/2048, 64x1/1024, ..., 64x1/64
The old ones are
1/4096, 1/2048, 1/1024, ..., 1/1
which is too much to create major imbalance of aging rates.
Signed-off-by: Wu Fengguang <wfg@mail.ustc.edu.cn>
---
include/linux/mmzone.h | 9 ++++++---
mm/vmscan.c | 18 ++++++++++++------
2 files changed, 18 insertions(+), 9 deletions(-)
--- linux.orig/include/linux/mmzone.h
+++ linux/include/linux/mmzone.h
@@ -251,10 +251,13 @@ struct zone {
/*
* The "priority" of VM scanning is how much of the queues we will scan in one
- * go. A value of 12 for DEF_PRIORITY implies that we will scan 1/4096th of the
- * queues ("queue_length >> 12") during an aging round.
+ * go. A value of 12 for DEF_PRIORITY/PRIORITY_STEPS implies that we will
+ * scan 1/4096th of the queues ("queue_length >> 12") during an aging round.
+ * Typically we will first try to scan 1/4096, then 64 times 1/2048, then 64
+ * times 1/1024, ..., at last 64 times 1/64.
*/
-#define DEF_PRIORITY 12
+#define PRIORITY_STEPS 64
+#define DEF_PRIORITY (12*PRIORITY_STEPS)
/*
* One allocation request operates on a zonelist. A zonelist
--- linux.orig/mm/vmscan.c
+++ linux/mm/vmscan.c
@@ -1006,7 +1006,7 @@ refill_inactive_zone(struct zone *zone,
* `distress' is a measure of how much trouble we're having reclaiming
* pages. 0 -> no problems. 100 -> great trouble.
*/
- distress = 100 >> zone->prev_priority;
+ distress = 100 >> (zone->prev_priority / PRIORITY_STEPS);
/*
* The point of this algorithm is to decide when to start reclaiming
@@ -1128,7 +1128,8 @@ shrink_zone(struct zone *zone, struct sc
* slowly sift through the active list.
*/
nr_active = zone->nr_scan_active + 1;
- nr_inactive = (zone->nr_inactive >> sc->priority) + SWAP_CLUSTER_MAX;
+ nr_inactive = ((zone->nr_inactive / PRIORITY_STEPS) >>
+ (sc->priority / PRIORITY_STEPS)) + SWAP_CLUSTER_MAX;
nr_inactive &= ~(SWAP_CLUSTER_MAX - 1);
sc->nr_to_scan = SWAP_CLUSTER_MAX;
@@ -1265,8 +1266,13 @@ int try_to_free_pages(struct zone **zone
zone->temp_priority = DEF_PRIORITY;
}
- /* The added 10 priorities are for scan rate balancing */
- for (priority = DEF_PRIORITY + 10; priority >= 0; priority--) {
+ /*
+ * The first PRIORITY_STEPS priorities are for scan rate balancing.
+ * One run of shrink_zone() can create at most 1/64 imbalance, here
+ * we first scan about 64 times 1/4096 for aging, just enough to
+ * rebalance it, before creating new imbalance.
+ */
+ for (priority = DEF_PRIORITY + PRIORITY_STEPS; priority >= 0; priority--) {
sc.nr_mapped = read_page_state(nr_mapped);
sc.nr_scanned = 0;
sc.nr_reclaimed = 0;
@@ -1301,7 +1307,7 @@ int try_to_free_pages(struct zone **zone
}
/* Take a nap, wait for some writeback to complete */
- if (sc.nr_scanned && priority < DEF_PRIORITY)
+ if (sc.nr_scanned && priority < DEF_PRIORITY - PRIORITY_STEPS)
blk_congestion_wait(WRITE, HZ/10);
}
out:
@@ -1464,7 +1470,7 @@ scan_swspd:
* OK, kswapd is getting into trouble. Take a nap, then take
* another pass across the zones.
*/
- if (total_scanned && priority < DEF_PRIORITY - 2)
+ if (total_scanned && priority < DEF_PRIORITY - PRIORITY_STEPS)
blk_congestion_wait(WRITE, HZ/10);
/*
--
next prev parent reply other threads:[~2005-12-07 10:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 10:47 [PATCH 00/16] Balancing the scan rate of major caches V3 Wu Fengguang
2005-12-07 10:47 ` [PATCH 01/16] mm: restore sc.nr_to_reclaim Wu Fengguang
2005-12-07 10:47 ` [PATCH 02/16] mm: simplify kswapd reclaim code Wu Fengguang
2005-12-07 10:47 ` [PATCH 03/16] mm: supporting variables and functions for balanced zone aging Wu Fengguang
2005-12-11 22:36 ` Marcelo Tosatti
2005-12-12 2:53 ` Wu Fengguang
2005-12-07 10:47 ` [PATCH 04/16] mm: balance zone aging in direct reclaim path Wu Fengguang
2005-12-07 10:48 ` [PATCH 05/16] mm: balance zone aging in kswapd " Wu Fengguang
2005-12-07 10:58 ` Wu Fengguang
2005-12-07 13:32 ` Wu Fengguang
2005-12-07 10:48 ` [PATCH 06/16] mm: balance slab aging Wu Fengguang
2005-12-07 11:08 ` Wu Fengguang
2005-12-07 11:34 ` Nick Piggin
2005-12-07 12:59 ` Wu Fengguang
2005-12-07 10:48 ` [PATCH 07/16] mm: balance active/inactive list scan rates Wu Fengguang
2005-12-07 10:48 ` Wu Fengguang [this message]
2005-12-07 10:48 ` [PATCH 09/16] mm: remove unnecessary variable and loop Wu Fengguang
2006-01-05 19:21 ` Marcelo Tosatti
2006-01-06 8:58 ` Wu Fengguang
2005-12-07 10:48 ` [PATCH 10/16] mm: remove swap_cluster_max from scan_control Wu Fengguang
2005-12-07 10:48 ` [PATCH 11/16] mm: let sc.nr_scanned/sc.nr_reclaimed accumulate Wu Fengguang
2005-12-07 10:48 ` [PATCH 12/16] mm: fold sc.may_writepage and sc.may_swap into sc.flags Wu Fengguang
2005-12-07 10:36 ` Nick Piggin
2005-12-07 11:11 ` Wu Fengguang
2005-12-07 11:12 ` Nick Piggin
2005-12-07 13:01 ` Wu Fengguang
2005-12-07 11:15 ` Wu Fengguang
2005-12-07 17:02 ` Martin Hicks
2005-12-07 23:15 ` Andrew Morton
2005-12-07 10:48 ` [PATCH 13/16] mm: fix minor scan count bugs Wu Fengguang
2005-12-07 10:32 ` Nick Piggin
2005-12-07 11:02 ` Wu Fengguang
2005-12-07 10:48 ` [PATCH 14/16] mm: zone aging rounds accounting Wu Fengguang
2005-12-07 10:48 ` [PATCH 15/16] mm: add page reclaim debug traces Wu Fengguang
2005-12-07 10:48 ` [PATCH 16/16] mm: kswapd reclaim debug trace Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051207105051.503626000@localhost.localdomain \
--to=wfg@mail.ustc.edu.cn \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=christoph@lameter.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.