From: Dave Jones <davej@redhat.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Missing break in timedia serial setup.
Date: Wed, 7 Dec 2005 12:44:09 -0500 [thread overview]
Message-ID: <20051207174409.GE3574@redhat.com> (raw)
In-Reply-To: <1133975119.2869.49.camel@laptopd505.fenrus.org>
On Wed, Dec 07, 2005 at 06:05:19PM +0100, Arjan van de Ven wrote:
> might as well add a /* fall through */ comment
> so that this doesn't come up again in the future..
Remove redundant assignment, and mark fallthrough.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.14/drivers/serial/8250_pci.c~ 2005-12-07 12:42:58.000000000 -0500
+++ linux-2.6.14/drivers/serial/8250_pci.c 2005-12-07 12:43:08.000000000 -0500
@@ -516,7 +516,7 @@ pci_timedia_setup(struct serial_private
break;
case 3:
offset = board->uart_offset;
- bar = 1;
+ /* FALLTHROUGH */
case 4: /* BAR 2 */
case 5: /* BAR 3 */
case 6: /* BAR 4 */
next prev parent reply other threads:[~2005-12-07 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 1:05 Missing break in timedia serial setup Dave Jones
2005-12-07 9:34 ` Russell King
2005-12-07 16:58 ` Dave Jones
2005-12-07 17:05 ` Arjan van de Ven
2005-12-07 17:44 ` Dave Jones [this message]
2005-12-07 18:11 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051207174409.GE3574@redhat.com \
--to=davej@redhat.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.