All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy_d_dunlap@linux.intel.com>
To: Randy Dunlap <randy_d_dunlap@linux.intel.com>
Cc: dom@ijichi.org, linux-ide@vger.kernel.org, axboe@suse.de,
	jgarzik@pobox.com
Subject: Re: [PATCH 6/6 update] SATA ACPI: ata_acpi functions
Date: Fri, 9 Dec 2005 10:52:38 -0800	[thread overview]
Message-ID: <20051209105238.61e1a137.randy_d_dunlap@linux.intel.com> (raw)
In-Reply-To: <20051208171008.47c688a9.randy_d_dunlap@linux.intel.com>

On Thu, 8 Dec 2005 17:10:08 -0800
Randy Dunlap <randy_d_dunlap@linux.intel.com> wrote:

> > > 
> > > ACPI_DEBUG in .config and also applied your debug patch
> > 
> > Yes, easy to reproduce with CONFIG_ACPI_DEBUG=y.
> > 
> > My new code frees a buffer that it does not own.
> > 
> > Just comment out or delete line 156 in drivers/scsi/ata_acpi.c,
> > which is:
> > 		ACPI_MEM_FREE(dinfo);
> > 
> > It shouldn't be there.
> 
> That's not quite correct.  It will boot & run with that
> change, but now the buffer isn't being freed at all.
> I'll rethink that and post a patch.

Dom,

I've updated the ata_apci.patch file to fix this bug.
I was misusing some of the ACPI memory alloc/free interfaces.

Updated file is at
http://www.xenotime.net/linux/SATA/2.6.15-rc/ata_acpi.patch

Thanks,
---
~Randy

  reply	other threads:[~2005-12-09 18:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20051202100119.032b242e.randy_d_dunlap@linux.intel.com>
2005-12-02 18:03 ` [PATCH 1/6] libata_suspend (Jens) Randy Dunlap
2005-12-02 18:04 ` [PATCH 2/6] SATA ACPI: make/config changes Randy Dunlap
2005-12-02 18:05 ` [PATCH 3/6] SATA ACPI: libata.h changes Randy Dunlap
2005-12-02 18:07 ` [PATCH 4/6] SATA ACPI: call new ACPI functions Randy Dunlap
2005-12-02 18:07 ` [PATCH 5/6] SATA ACPI: kernel-doc Randy Dunlap
2005-12-02 18:08 ` [PATCH 6/6] SATA ACPI: ata_acpi functions Randy Dunlap
2005-12-06 21:58   ` [PATCH 6/6 update] " Randy Dunlap
2005-12-07 16:36     ` Dominic Ijichi
2005-12-07 17:16       ` Randy Dunlap
2005-12-07 17:24         ` Dominic Ijichi
2005-12-07 18:34           ` Randy Dunlap
2005-12-08  9:43             ` Dominic Ijichi
2005-12-09  0:16               ` Randy Dunlap
2005-12-09  0:20                 ` Dominic Ijichi
2005-12-09  1:03                   ` Randy Dunlap
2005-12-09  1:10                     ` Randy Dunlap
2005-12-09 18:52                       ` Randy Dunlap [this message]
2005-12-10 19:01                         ` Dominic Ijichi
2005-12-12  0:16                           ` Randy.Dunlap
2005-12-02 18:15 ` [PATCH 0/6] SATA use ACPI methods for PM Randy Dunlap
2005-12-12  0:24 [PATCH 6/6 update] SATA ACPI: ata_acpi functions Dominic ES. Ijichi
2005-12-12  0:44 ` Randy.Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2005-12-12  1:24 Dominic ES. Ijichi
2005-12-12  2:13 ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051209105238.61e1a137.randy_d_dunlap@linux.intel.com \
    --to=randy_d_dunlap@linux.intel.com \
    --cc=axboe@suse.de \
    --cc=dom@ijichi.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.