All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Domsch <Matt_Domsch@dell.com>
To: akpm@osdl.org, linux-kernel@vger.kernel.org
Cc: minyard@acm.org
Subject: [PATCH 2.6] ipmi: panic generator ID
Date: Fri, 9 Dec 2005 12:03:05 -0600	[thread overview]
Message-ID: <20051209180305.GB29231@lists.us.dell.com> (raw)

The IPMI specifcation says the generator ID is 0x20, but that is for
bits 7-1.  Bit 0 is set to specify it is a software event.  The
correct value is 0x41.  Without this fix, panic events written into
the System Event Log appear to come from an "unknown" generator,
rather than from the kernel.

Signed-off-by: Jordan Hargrave <Jordan_Hargrave@dell.com>
Signed-off-by: Matt Domsch <Matt_Domsch@dell.com>
Ack'd-by: Corey Minyard <minyard@acm.org>


-- 
Matt Domsch
Software Architect
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

--- linux-2.6/drivers/char/ipmi/ipmi_msghandler.c	Tue Dec  6 12:53:19 2005
+++ linux-2.6/drivers/char/ipmi/ipmi_msghandler.c	Fri Dec  9 10:27:42 2005
@@ -2986,7 +2986,7 @@ static void send_panic_events(char *str)
 	msg.cmd = 2; /* Platform event command. */
 	msg.data = data;
 	msg.data_len = 8;
-	data[0] = 0x21; /* Kernel generator ID, IPMI table 5-4 */
+	data[0] = 0x41; /* Kernel generator ID, IPMI table 5-4 */
 	data[1] = 0x03; /* This is for IPMI 1.0. */
 	data[2] = 0x20; /* OS Critical Stop, IPMI table 36-3 */
 	data[4] = 0x6f; /* Sensor specific, IPMI table 36-1 */

             reply	other threads:[~2005-12-09 18:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-09 18:03 Matt Domsch [this message]
2005-12-10  1:32 ` [PATCH 2.6] ipmi: panic generator ID Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051209180305.GB29231@lists.us.dell.com \
    --to=matt_domsch@dell.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.