From: Muli Ben-Yehuda <mulix@mulix.org>
To: Alex Williamson <alex.williamson@hp.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] xencons missing string allocation
Date: Fri, 09 Dec 2005 20:54:48 +0200 [thread overview]
Message-ID: <20051209185448.GD9830@granada.merseine.nu> (raw)
In-Reply-To: <1134153451.6136.14.camel@tdi>
On Fri, Dec 09, 2005 at 11:37:31AM -0700, Alex Williamson wrote:
>
> I was trying to boot dom0 w/ "xencons=ttyS1 console=ttyS1". It gives
> some weird error messages:
>
> Warning: dev (ttyS2) tty->count(2) != #fd's(1) in release_dev
> Warning: dev (ttyS2) tty->count(3) != #fd's(1) in tty_open
>
> And blows up with a page fault. The page fault is because we don't
> actually allocate a buffer for the tty driver name.
Errr... the patch looks curious. Why does it work when ->name points
to the heap but not when it points to the data segment? they should be
equivalent and many tty drivers appear to set ->name to the data
segment. Is something trying to modify xencons_driver->name later?
(also, do you know why do we need the fugly DRV() macro in that code?)
Cheers,
Muli
--
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/
next prev parent reply other threads:[~2005-12-09 18:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-09 18:37 [PATCH] xencons missing string allocation Alex Williamson
2005-12-09 18:54 ` Muli Ben-Yehuda [this message]
2005-12-09 20:37 ` Alex Williamson
2005-12-10 0:00 ` Alex Williamson
2005-12-10 15:06 ` Keir Fraser
2005-12-10 16:27 ` Alex Williamson
2005-12-10 23:12 ` Keir Fraser
2005-12-12 22:00 ` Alex Williamson
2005-12-13 1:57 ` Keir Fraser
2005-12-13 20:44 ` Alex Williamson
2005-12-13 21:00 ` Keir Fraser
2005-12-12 9:40 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051209185448.GD9830@granada.merseine.nu \
--to=mulix@mulix.org \
--cc=alex.williamson@hp.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.